fix(telemetry): accept exact SemVer prereleases - #382
Merged
Conversation
OpenObserve publishes an immutable latest release whose semantic version carries an rc suffix. Accept bounded SemVer prerelease identities for the store while preserving exact asset name, path, host, and SHA256 validation; malformed and mutable identities remain rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The telemetry manifest accepted only
vMAJOR.MINOR.PATCH, while an official immutable release can carry a valid SemVer prerelease suffix. The current OpenObserve latest release isv1.0.0-rc1; its archive has an official checksum and contains the upstream SQLite single-writer fix needed by the fleet.This accepts bounded SemVer prerelease identities for the store only. Exact archive filename, release path, official host and SHA256 remain mandatory, so
latest, path fragments and malformed versions are still rejected.Verification:
go test ./internal/telemetrymanifestmake verify