fix(validate): auxiliary checks resolve engine inputs through the source layout - #67
Merged
Merged
Conversation
…rce layout An external estate pins the engine as a module and owns only its anchor, skills and exceptions -- yet doctor's auxiliary checks read the migration registry, harness registry and bridge, harness profiles, bundle trust, source register and plugin static files from the authority root, so an estate doctor could never be green: five unconditional read failures and a phantom invalid plugin source on every run (#65). ValidateCanonical now takes the engine root for engine-distribution inputs, BuildPackage reads plugin static files from a staticRoot, and the harness validators resolve the same development source layout the harness operations already use. On the engine repository both roots coincide and nothing changes. The paired test pins the split and its control: collapsed roots lose exactly the five engine inputs. Fixes #65 Claude-Session: https://claude.ai/code/session_01LsGid6U5RrQdFvJmvYdGCF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #65. Doctor and the auxiliary validators (schemas, plugins, harness) now resolve engine-distribution inputs through
ResolveDevelopmentSourceLayout— the same resolution the harness operations already perform — instead of the authority root. On the engine repo both roots coincide (no behavior change, full suite green); on the live private estate this takes doctor from fiveGDS_INPUT_READ_FAILED+GDS_PLUGIN_SOURCE_INVALIDto schemas/estate/skills/plugins/harness-registry allpass(verified live before this PR).Paired test pins the split: external layout validates clean, collapsed roots lose exactly the five engine inputs.
https://claude.ai/code/session_01LsGid6U5RrQdFvJmvYdGCF