Conversation
Add a new GitHub Actions lint workflow for pull requests, pushes to main/localisation, and manual runs. Run content validation first, then run formatting checks only on changed files to avoid blocking on legacy formatting drift. Add npm scripts for standard linting, full linting, format checks, and automatic fixes: lint for default content validation lint:all for combined format and content checks lint:format for Prettier check lint:fix for automatic formatting Add Prettier as a direct dev dependency and update the lockfile accordingly. Simplify Prettier configuration to valid formatter-only options and remove editor-specific settings. Add a Prettier ignore list for dependencies, generated artifacts, and package-lock.json. Update local testing docs with the new lint commands and recommended default flow. Result: reliable CI linting for new changes while intentionally ignoring legacy formatting debt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive linting workflow for the project, adds and updates formatting configuration, and documents the new linting commands. The main goal is to automate and standardize code and content linting across the repository, improving code quality and consistency.
Linting workflow and automation:
.github/workflows/lint.ymlto automatically run linting and formatting checks on pull requests and pushes to key branches, as well as on manual dispatch. The workflow installs dependencies, runs content lint, detects changed files, and applies Prettier formatting checks to only those files.Formatting configuration:
.prettierignorefile to exclude common build, dependency, and output directories from Prettier formatting..prettierrcfile to include only core Prettier configuration options, removing editor-specific settings and language overrides.Package and dependency updates:
package.jsonto add scripts for running content and formatting lint (lint,lint:all,lint:format,lint:content,lint:fix), and addedprettierandlintas development dependencies. Also updated@crowdin/clito the latest patch version. [1] [2]Documentation:
readme/testing.mdto document the new linting commands and fixed minor formatting issues for consistency. [1] [2]