Repository navigation
Add tactile tool - #1349
Draft
lotusl-code wants to merge 4 commits into
Draft
Add tactile tool#1349lotusl-code wants to merge 4 commits into
lotusl-code wants to merge 4 commits into
Conversation
Signed-off-by: Lotus Li <lotusl@nvidia.com>
1. Refresh once after each queued event, including rejected edits. Update segment choices before selecting newly added or cross-hand rows. 2. Reuse FK snapshots through a bounded, instance-owned LRU cache. 3. Redraw static geometry only after changes while retaining live playback and connection-status updates. 4. Cache received metadata parsing and validation by content, and reuse draft validation results during drawing. 5. Share common-number inspection between pose and weight controls. 6. Remove redundant weight clamping after the existing range checks. 7. Remove the repeated SDK revision assignment when a background job ends. Validation: Ruff 0.15.1 lint and formatting checks, package syntax checks, and focused regression checks for refresh ordering, static/live updates, cache invalidation and lifetime, mixed inspector fields, and SDK revisions. Browser and numerical integration remain unverified because the inspection interpreter lacks numpy, trimesh, viser, and yourdfpy. Signed-off-by: Lotus Li <lotusl@nvidia.com>
lotusl-code
marked this pull request as draft
October 27, 2026 04:45
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| for i, p in enumerate(rows): | ||
| try: | ||
| yield i, root @ matrix(p) | ||
| except (ValueError, TypeError): |
| attachments[sid] = ( | ||
| np.linalg.inv(fk[link]) @ root @ matrix(d.arrays[FIELDS[0]][i]) | ||
| ) | ||
| except (KeyError, TypeError, ValueError): |
| 80, | ||
| 255 * (1 - weights[self.slot]), | ||
| ) | ||
| except (IndexError, TypeError, ValueError): |
| d.editor["segment_ids"][j] | ||
| ) | ||
| ) | ||
| except (IndexError, TypeError, ValueError): |
Use the existing schema JSON functions for loading, saving, backups, export, SDK input and saved-state comparisons. Remove editor-extension persistence, model restoration, resource-path rewriting and the editable/numerical mode. Drop editor JSON, correspondence CSVs, saved reports, --report and unused taxel-ID bookkeeping. Keep incomplete values saveable, preserve raw weights and array ordering, and validate formal exports separately. Update the README for values-only files and explicit hand assignment. Validation: Ruff 0.15.1 lint/format checks, syntax checks, actual JSON save/load and export checks, CLI checks, and focused UI ordering/repair checks. No new functions or classes were added. SDK transport and UI checks used stubs; actual SDK encoding and browser rendering remain unverified. Signed-off-by: Lotus Li <lotusl@nvidia.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.