Skip to content

[1.6.x] build: preflight xkbcommon and document GLFW prerequisites - #1379

Merged
jiwenc-nv merged 1 commit into
release/1.6.xfrom
codex/backport-pr-1355-1.6
Oct 28, 2026
Merged

jiwenc-nv merged 1 commit into
release/1.6.xfrom
codex/backport-pr-1355-1.6

Conversation

@fvaloppi-nv

Copy link
Copy Markdown
Contributor

Summary

Validation

  • SKIP=check-copyright-year pre-commit run --all-files
  • make current-docs from docs/ (Sphinx warnings treated as errors)
  • Focused CMake configure with BUILD_VIZ=ON, confirming the preflight reports xkbcommon>=0.5.0 and libxkbcommon-dev before dependency fetching

Original PR: #1355
Original commit: 2ba4cedab5d2fe7b207b9aa5f576a012d3ff431a

Catch missing Wayland keyboard development files before fetching GLFW, and direct source-build entry points to complete shared prerequisites.

Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
Signed-off-by: fvaloppi-nv <fvaloppi@nvidia.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@jiwenc-nv
jiwenc-nv merged commit 0b9ed97 into release/1.6.x Oct 28, 2026
33 checks passed
@jiwenc-nv
jiwenc-nv deleted the codex/backport-pr-1355-1.6 branch October 28, 2026 16:07
github-actions Bot added a commit that referenced this pull request Oct 28, 2026

This branch was successfully deployed

1 active deployment
dev — b754089e Deployed Oct 28, 2026 by fvaloppi-nv via publish-wheel #6140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants