Skip to content

EgoPost: restrict checkpoint deserialization - #1384

Draft
fvaloppi-nv wants to merge 1 commit into
mainfrom
codex/fix-safe-model-loading
Draft

fvaloppi-nv wants to merge 1 commit into
mainfrom
codex/fix-safe-model-loading

Conversation

@fvaloppi-nv

@fvaloppi-nv fvaloppi-nv commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Description

Restrict EgoPost checkpoint deserialization to tensors and primitive metadata.

  • This was reported internally by Sonar.
  • Pass weights_only=True at each EgoPost torch.load call site.
  • Prevent checkpoint pickle globals from executing during model loading.
  • Keep concise comments beside each loader documenting the data-only checkpoint contract.
  • Do not provide an unsafe compatibility fallback.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Testing

  • python3 -m compileall on all changed Python modules
  • AST validation that every EgoPost torch.load call explicitly sets weights_only=True
  • SKIP=check-copyright-year pre-commit run --all-files

Checklist

  • The branch is based on main
  • All changed Python files are formatted
  • The commit includes DCO sign-off
  • No unsafe deserialization fallback is present

Signed-off-by: fvaloppi-nv <fvaloppi@nvidia.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch was successfully deployed

1 active deployment
dev — 7bc6e191 Deployed Oct 28, 2026 by fvaloppi-nv via publish-wheel #6159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants