Skip to content

fix(review): keep the reviewer roster limited to collaborators #5549

Open

Description

@purp

User Story

As an OpenShell maintainer investigating Review Readiness failures, I need the reviewer roster to contain only accounts GitHub can request so valid review requests succeed.

Problem Statement

REVIEWERS.md includes non-collaborators. GitHub rejects a reviewer-request batch containing one of these accounts with HTTP 422. A request for only 2000krysztof on #5540 confirmed the collaborator restriction.

Impact / Why This Matters

An ineligible roster entry blocks requests to eligible reviewers. Roster changes need a check that catches this before merge.

Acceptance Criteria

  • Remove every current non-collaborator from REVIEWERS.md, preserving the category definitions and eligible reviewers.
  • Branch Checks validates every roster handle against all pages of GitHub's repository collaborator list, reporting sorted offending handles and failing on lookup errors.
  • Read, triage, and outside collaborators remain eligible; write access is not required.
  • Offline tests cover eligible accounts, non-collaborators, pagination, and lookup failures.

Reproduction Steps

  1. Select a non-collaborator listed in OpenShell's reviewer roster.
  2. Request that account as a PR reviewer.
  3. Observe HTTP 422: “Reviews may only be requested from collaborators.”

Environment

  • Repository: NVIDIA/OpenShell
  • Integration: GitHub Review Readiness and reviewer roster

This replaces #5539 and #5540 with a smaller roster cleanup and validation check.

Activity

  1. added
    area:buildCI/CD workflows, releases, build targets, packaging, and artifact publication.
    topic:dxMaking OpenShell easy to contribute to for humans and agents.
    on Nov 15, 2026
  2. alangou commented on Nov 17, 2026

    @alangou
    Contributor

    Additional confirmed case: PR #5637, head f7f1c30e37b52bcc8baca7a586a72f92a4ee371e.

    With area:build and topic:security, Review Readiness fails while requesting reviewers. GitHub returns HTTP 422: "Reviews may only be requested from collaborators."

    Repository collaborator checks during the investigation returned 404 for the selected roster entries ChristianZaccaria and 2000krysztof. The six other selected accounts passed the collaborator check. A separately requested review from SDAChess approved the same head, and OpenShell / Maintainer Approval is green. The approval does not resolve the invalid automatic reviewer-request batch.

    The workflow loads REVIEWERS.md and its routing helper from the default branch. The cleanup and membership validation described in this issue therefore need to land on main before rerunning Review Readiness on #5637. This reproduces the existing issue's scope; the dependency-only PR does not need to change reviewer policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:buildCI/CD workflows, releases, build targets, packaging, and artifact publication.topic:dxMaking OpenShell easy to contribute to for humans and agents.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions