feat(sandbox): add canonical main process - #2726
Open
drew wants to merge 7 commits into
Open
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-2726.docs.buildwithfern.com/openshell |
This comment was marked as resolved.
This comment was marked as resolved.
drew
force-pushed
the
codex/2710-canonical-main-process
branch
from
August 13, 2026 19:58
f192d21 to
05983c0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
drew
force-pushed
the
codex/2710-canonical-main-process
branch
3 times, most recently
from
August 18, 2026 23:44
5040f5c to
3416111
Compare
9 tasks
Closes #2710 Persist and supervise one canonical workload per sandbox, attach sandbox connect to its retained session, and make every unexpected main-process exit terminal. Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
force-pushed
the
codex/2710-canonical-main-process
branch
from
August 19, 2026 00:28
3416111 to
d52f50e
Compare
drew
marked this pull request as ready for review
August 19, 2026 00:30
drew
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
August 19, 2026 00:30
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add one canonical main process to every sandbox and make it the process observed by
sandbox connect. The supervisor retains and multiplexes its session across reconnects, whilesandbox execremains an independent process path. Any unexpected canonical-process exit, including exit code 0, is persisted on the sandbox and transitions it toError; intentional stop/start teardown is exempt.Related Issue
Closes #2710
Changes
commandandttydirectly to the public and compute-driver sandbox specs, with sandbox-owned main instance and exit status./bin/bash -lTTY main process.sandbox connectthrough the retained main session while preserving independent exec, SFTP, editor, and forwarding behavior.sandbox createargv the persisted main process, attach interactively by default, and add--detach.Testing
mise run pre-commitmise run testwith an isolated system-gateway directory--no-keepChecklist