Skip to content

ci(review): move unaccepted PRs back to draft - #4948

Draft
purp wants to merge 6 commits into
NVIDIA:mainfrom
purp:ci/4839-draft-unaccepted-prs/purp
Draft

purp wants to merge 6 commits into
NVIDIA:mainfrom
purp:ci/4839-draft-unaccepted-prs/purp

Conversation

@purp

@purp purp commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Move unaccepted PRs back to draft when opened ready for review or marked ready, before requesting reviewers. Accept authors with write access or state:accepted on the PR or a referenced issue. Explain the first automatic conversion with one comment; subsequent unaccepted attempts return to draft without another comment.

Depends on #4863. This branch includes its reviewer registry and routing changes; the acceptance layer can be reviewed separately in this comparison.

Related Issue

Related to #4839. Illustrative draft policy is tracked separately in #4952.

Changes

  • Share one acceptance implementation between Review Readiness and PR Issue Acceptance, removing the duplicate JavaScript helper.
  • Preserve the existing acceptance check's name, triggers, and read-only behavior, using the PR event payload for its metadata.
  • Check referenced issues, stop at the first accepted issue, and validate acceptance before loading the reviewer roster.
  • Add the requested first-conversion comment and suppress repeats using the existing PR comment history.
  • Remove the mechanism explanation from CONTRIBUTING.md and prune duplicated and low-value tests.

Testing

  • 56 focused Python tests pass, covering both callers, PR/issue acceptance, one-time comments, pagination, reviewer preservation, and failure boundaries.
  • Read-only live GraphQL/CLI checks, workflow shell syntax, and whitespace checks pass.
  • Ruff, Actionlint, and Markdown lint were unavailable; downloads are blocked.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

@copy-pr-bot

copy-pr-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@TechWizard9999

Copy link
Copy Markdown

Coordinating note: PR #4999 has been opened to address #4952 by defining the policy and bounds for illustrative drafts and exempting draft PRs from the issue acceptance check while in draft. Once merged, DRAFT_COMMENT in this PR can reference CONTRIBUTING.md#illustrative-drafts-for-unaccepted-work.

@purp
purp requested a review from elezar October 31, 2026 00:11
@purp

purp commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@elezar this is the auto-drafting PR we discussed a couple of weeks ago as an alternative to #4543 ... have a look next week when you have a moment?

@github-actions

Copy link
Copy Markdown

This pull request has had no activity for 14 days and is now marked stale.

@github-actions github-actions Bot added the state:stale Inactive item at risk of automatic closure. label Nov 14, 2026
@purp purp added area:build CI/CD workflows, releases, build targets, packaging, and artifact publication. topic:dx Making OpenShell easy to contribute to for humans and agents. labels Nov 15, 2026
@github-actions github-actions Bot removed the state:stale Inactive item at risk of automatic closure. label Nov 15, 2026
purp added 6 commits November 15, 2026 15:21
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
@purp
purp force-pushed the ci/4839-draft-unaccepted-prs/purp branch from 130563e to be7d0b9 Compare November 15, 2026 15:29
@elezar

elezar commented Nov 16, 2026

Copy link
Copy Markdown
Member

I think we can rather take this forward instead of #4543.

@elezar elezar mentioned this pull request Nov 16, 2026
5 tasks done
@TechWizard9999

Copy link
Copy Markdown

Can we take this ? forword @elezar

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build CI/CD workflows, releases, build targets, packaging, and artifact publication. topic:dx Making OpenShell easy to contribute to for humans and agents.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants