Skip to content

fix(review): validate reviewer roster eligibility - #5550

Open
purp wants to merge 3 commits into
NVIDIA:mainfrom
purp:fix/5549-reviewer-roster-validation/purp
Open

purp wants to merge 3 commits into
NVIDIA:mainfrom
purp:fix/5549-reviewer-roster-validation/purp

Conversation

@purp

@purp purp commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Remove ineligible reviewer-roster entries and validate the roster in Branch Checks before merge. Preserve listed read, triage and outside collaborators, and recognize accounts with confirmed effective write or admin access.

Why

Maintainers need automatic review requests to reach eligible reviewers instead of failing an entire batch with HTTP 422. The existing roster contains accounts GitHub cannot request.

The validation must also recognize effective access. In the Actions diagnostic, an account was absent from both membership APIs while its permission response reported admin. GitHub documents write access as sufficient for requesting a review, and the permission endpoint reports the highest effective base permission. Public read permission alone does not establish collaborator membership.

Related Issue

Closes #5549.

Changes

  • Remove 21 memberships belonging to 10 ineligible accounts, preserving category definitions and eligible memberships.
  • Add a read-only Reviewer Roster job to Branch Checks for PR mirrors and merge groups. Reuse the existing roster parser and consume all collaborator-list pages.
  • For accounts absent from the list, accept only confirmed write or admin base permission. Reject unlisted read or none; fail on lookup errors or malformed responses. Custom role names do not establish eligibility.
  • Remove the temporary diagnostics and raw HTTP-header fallback. Add no dependency, access grant or token-permission change.
  • Protect the validator with CODEOWNERS and document the check.

Testing

  • 54 offline tests pass: 45 reviewer-routing tests and 9 eligibility tests. The administrator regression reproduces the old rejection before the fix.
  • Live local validation rejects the original roster's 10 ineligible accounts and accepts the cleaned roster's 17 accounts.
  • Targeted Ruff lint/format, ty and git diff --check pass.
  • Independent review found no blocking issues in the final source and tests.
  • Branch Checks for head d6d57f0d passed. The real Actions-token Reviewer Roster job accepted all 17 accounts.
  • Runtime/E2E suites are not applicable to this repository-tooling change.

Checklist

  • Follows Conventional Commits.
  • DCO sign-off included on every commit.
  • Maintainer/code-owner review.

Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
@purp
purp requested review from a team, derekwaynecarr, mrunalp and sjenning as code owners November 14, 2026 01:30
@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 14, 2026
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
@purp
purp enabled auto-merge November 14, 2026 04:55
@purp purp added area:build CI/CD workflows, releases, build targets, packaging, and artifact publication. topic:dx Making OpenShell easy to contribute to for humans and agents. labels Nov 14, 2026
@purp purp added meta:labeler-checkpoint Temporary label used by /label-issue to record a verified classification checkpoint. and removed meta:labeler-checkpoint Temporary label used by /label-issue to record a verified classification checkpoint. labels Nov 15, 2026
@copy-pr-bot

copy-pr-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@alangou

alangou commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

/ok to test 09b8d53

@alangou

alangou commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

/ok to test 2853ff2

@alangou

alangou commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

/ok to test 4449a61

@alangou alangou changed the title fix(review): validate reviewer roster collaborator membership fix(review): validate reviewer roster eligibility Nov 17, 2026
Check effective write or admin access before rejecting an account omitted from the collaborator list. Keep public read access and lookup errors rejected, with regression tests and matching contributor guidance.

Signed-off-by: Adrien Langou <alangou@nvidia.com>
@alangou
alangou force-pushed the fix/5549-reviewer-roster-validation/purp branch from 4449a61 to d6d57f0 Compare November 17, 2026 14:30
@alangou

alangou commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

/ok to test d6d57f0

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build CI/CD workflows, releases, build targets, packaging, and artifact publication. state:accepted A maintainer decided OpenShell should pursue this issue topic:dx Making OpenShell easy to contribute to for humans and agents.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(review): keep the reviewer roster limited to collaborators

2 participants