Skip to content

feat(docker): preserve workspace storage during stopped image updates - #5617

Open
senthilr-nv wants to merge 8 commits into
NVIDIA:mainfrom
senthilr-nv:feat/5484-docker-image-updates-main/senthilr-nv
Open

senthilr-nv wants to merge 8 commits into
NVIDIA:mainfrom
senthilr-nv:feat/5484-docker-image-updates-main/senthilr-nv

Conversation

@senthilr-nv

@senthilr-nv senthilr-nv commented Nov 16, 2026 •

Copy link
Copy Markdown

Summary

Add opt-in persistent /sandbox storage and image-only updates for stopped Docker sandboxes through the existing SandboxUpdates.UpdateSandbox contract. Replacing the workload container preserves the native sandbox identity and its owned workspace volume; Start remains a separate operation.

Related Issue

Closes #5484

Changes

  • Add persist_workspace = false to the Docker driver configuration. Newly created default /sandbox workspaces can use driver-owned local volumes; existing writable-layer workspaces are not migrated.
  • Record storage authority in protected per-sandbox workspace-storage.json, bound into both private bootstrap and runtime descriptor. Recheck volume identity, namespace and workload UID/GID even when external resource admission is disabled. Preserve all caller template labels; labels cannot authorize persistent storage. Failed creation retains the ownership record, and replay rejects missing/changed authority before mutation. Stop retains data; explicit Delete removes admitted owned storage and reports failures.
  • Implement the optional configuration-update RPC and gateway capability registration for persistent workspaces. Require a stopped workload, locally cached source/target images and no image-declared volumes. Require the target to declare an explicit numeric non-root USER UID:GID matching the recorded identity; reject symbolic and implicit identity representations before saving intent or deleting the source. Reject command/environment changes and incompatible layouts before replacement.
  • Serialize lifecycle actions with image replacement. Persist private operation state so an interrupted accepted update can resume without adopting an unrelated same-name container; retain resources during the replacement gap and refuse Start until the update is settled.
  • Before a stopped Start with fresh launch authentication, check each bootstrap/descriptor file against the accepted immutable bindings independently. Repair interrupted credential publication, then require generation/session/evidence consistency before staging or starting. Running or unauthenticated starts retain the complete precheck.
  • Add mock-Docker regression tests and a reproducible opt-in live driver test for identity rejection, A-to-B replacement, retained files, replay and recovery after source deletion. Update Docker configuration/runtime documentation and the related public/contributor skills.

Release Notes

Docker gateways can opt new workspaces into persistent /sandbox storage and update their stopped workload image without changing the OpenShell sandbox ID. The gateway must separately enable sandbox updates. Existing writable-layer workspaces remain unchanged.

Testing

Current local validation uses Rust 1.95.0 on macOS arm64. This branch incorporates main at e8ba30fdeff5f9bcc985b2c11064f0b0deb3c168.

  • Root and feature-workspace cargo fmt --all --check
  • cargo test --locked -p openshell-driver-docker --lib: 190 passed, 0 failed, 3 ignored. The default suite uses mock Docker endpoints; live tests require explicit opt-in.
  • cargo clippy --locked -p openshell-driver-docker --all-targets -- -D warnings
  • cargo clippy --locked -p openshell-gateway --no-default-features --features compute-driver-docker,telemetry,vendored-z3 -- -D warnings
  • Focused docker-updates suite clippy with --all-targets -- -D warnings.
  • Documentation navigation check and Fern check. Fern reports no errors and three warnings (configuration-page MDX parsing, unavailable authenticated redirect check, light-mode accent contrast), also reproduced on stock v0.1.8.
  • Both review regressions reproduced on the reviewed source before fixing: incompatible target USER accepted, and Start rejected interrupted bootstrap/descriptor publication before repair.
  • cargo test --locked -p openshell-driver-docker --lib live_stopped_image_replacement -- --ignored --nocapture: 1 passed on Docker 29.8.0 using the committed Alpine fixture. Verified incompatible numeric/symbolic refusal, same sandbox/volume and retained file bytes, A-to-B image contents, settled replay and recovery after source deletion. This is driver integration, not gateway/supervisor E2E.
  • Start regression reaches the staging precondition after repairing a fresh-bootstrap/old-descriptor pair. Negative cases cover running inspection, stale list state, absent fresh authentication, and changed sandbox/container/image/identity/workspace bindings.
  • Required Branch Checks passed on 0acdea553: run 44005057843, attempt 1.
  • Full local gateway/supervisor Docker qualification on 0acdea553: mTLS client rejection/authorization, real API and SSH execution on A/B images, retained sandbox/SSH/workspace identity, gateway restart and Stop/Start, interrupted credential-publication repair through Start, and API removal of the workload, all four owned volumes and private runtime state. docker-updates: 1 passed, 0 failed, 0 ignored. Gateway/CLI built from this head; Linux sandbox/supervisor artifacts from this exact head’s CI run 44005058200 and packaged with the official Dockerfiles. See the qualification comment for commands and hashes.
  • Required repository runtime E2E passed on 0acdea553: run 44005058200, attempt 1, including both Docker conformance lanes and Kubernetes/k3s-ha conformance. The prior-head cleanup timeout did not recur.

Checklist

  • Follows Conventional Commits.
  • All contribution commits are signed off (DCO).
  • All eight contribution commits have GitHub-verified SSH signatures. The review follow-up is an ordinary fast-forward commit; the original five commits are preserved.
  • Relevant Docker configuration, runtime, crate and troubleshooting documentation updated.
  • Final-head compatibility review: complete, no unaddressed breaks, zero findings across all nine required surfaces.
  • Compatibility advisory addressed with independent protected driver state. Generic and Docker-specific workspace label names remain caller data. Regressions cover label preservation/legacy admission, unrecorded deletion refusal, missing/corrupt/changed records, replay authority, and failed-create record retention.

Refs NVIDIA#5484. Keep workspace data separate from disposable runtime resources, validate retained volume identity, and preserve legacy layouts. Workload image replacement and native qualification remain separate work.

Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
Refs NVIDIA#5484. Preserve native identity and recorded data volumes while replacing workload bytes and refreshing container-bound runtime evidence. Keep update capability negotiation disabled pending lifecycle/restart integration and native qualification.

Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
Selected upstream target: e8ba30f

Retain upstream shutdown grace and mutation-audit behavior alongside opt-in Docker workspace persistence and image-only configuration updates. Resolve the README overlap by documenting both the persistent-data contract and current shutdown behavior.

Validation: formatting and 180 Docker driver unit tests passed; two live Docker tests remain ignored. Further lint and native integration qualification are recorded separately.
Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
Name the feature-selected registration array before iteration so Clippy does not flag the supported Docker-only build as a single-element loop. Driver entries, ordering and registration behavior remain unchanged.

Validation: cargo fmt --all --check and Docker-only gateway Clippy with compute-driver-docker, telemetry and vendored-z3, all targets and warnings denied.
Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 16, 2026
@senthilr-nv
senthilr-nv force-pushed the feat/5484-docker-image-updates-main/senthilr-nv branch from f0584ca to 8b9da39 Compare November 16, 2026 21:10
@copy-pr-bot

copy-pr-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@senthilr-nv
senthilr-nv marked this pull request as ready for review November 16, 2026 21:11

@johntmyers johntmyers left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gator-agent

PR Review Status

The Docker storage and stopped-image-update workflow fits accepted issue #5484. Two correctness problems need fixes before pipeline handoff: target identity compatibility is not checked, and an interrupted credential rotation can prevent subsequent Starts.

Action required: @senthilr-nv, address the two inline findings and add regression coverage for their failure paths.

Blocking findings:

  • GATOR-8b9da399-01: Reject incompatible target workload identities before replacement.
  • GATOR-8b9da399-02: Preserve Start retry recovery after interrupted credential rotation.

Carried findings: None.

Non-blocking suggestions:

  • Update the Kubernetes-only update wording in skills/openshell-cli/SKILL.md and .agents/skills/helm-dev-environment/SKILL.md to reflect the restricted Docker workflow.
Gator metadata
  • Validation: Implements accepted Docker-specific issue #5484 through the existing update contract.
  • Docs: Docker configuration, runtime and sandbox update pages updated; existing navigation suffices.
  • Checks: Existing current-head workflows succeeded; review was code-only and no local tests were run.
  • E2E: Required for Docker lifecycle/storage changes; existing E2E jobs were skipped without test:e2e. Dispatch follows resolution of blocking review findings. Live A-to-B and interruption qualification remains an author-declared merge gate.
  • Head SHA: 8b9da3993e232e484313adc2158d87284381bd9a
  • Base SHA: e8ba30fdeff5f9bcc985b2c11064f0b0deb3c168
  • Merge base SHA: e8ba30fdeff5f9bcc985b2c11064f0b0deb3c168
  • Patch ID: 3240105f250b3ea1397f7555296845db490815f3
  • Gator payload: 13
  • Review mode: initial
  • Previous reviewed SHA: none
  • Review budget exhausted: no
  • Maintainer decision required: no
  • Next state: gator:in-review

@johntmyers johntmyers added the gator:in-review Gator is reviewing or awaiting PR review feedback label Nov 16, 2026
Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
@github-actions

Copy link
Copy Markdown

Compatibility review (advisory)

New or updated breaking changes; see the full report for all findings.

1. api-behavior — No explicit risk acceptance found

Docker previously preserved spec.template.labels keys openshell.ai/workspace-storage and openshell.ai/workspace-volume-identity; it now strips them on create and interprets them as persistence metadata on existing containers.

  • Impact: Existing Docker sandboxes carrying either previously accepted label can fail StartSandbox with FAILED_PRECONDITION after upgrade, even with persist_workspace=false.
  • Action: For v0.1.9, preserve legacy template labels and distinguish driver-created persistent workspaces without reinterpreting existing caller labels.
  • PR: feat(docker): preserve workspace storage during stopped image updates #5617
Review details
  • Execution: complete
  • Candidate: PR #5617 (32deb26a7043be52661af7968db86352107bd1c2)
  • Baseline: e8ba30fdeff5f9bcc985b2c11064f0b0deb3c168 (e8ba30fdeff5f9bcc985b2c11064f0b0deb3c168)
  • Reviewed: rust-sdk, python-sdk, typescript-sdk, api-behavior, cli, configuration, policy, helm, state

Advisory review; publication gates are unchanged.

Branch check run

@johntmyers johntmyers added the test:e2e Requires end-to-end coverage label Nov 17, 2026
@github-actions

Copy link
Copy Markdown

Label test:e2e applied for fc1ce9d. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway, sandbox, and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

@johntmyers

Copy link
Copy Markdown
Collaborator

gator-agent

PR Review Status

Thanks @senthilr-nv. I checked your target-identity validation and interrupted credential-publication fixes against the previous review and the latest author delta. Both findings are fixed, their Gator threads are resolved, and no blocking code findings remain.

The target preflight now rejects incompatible or unsupported identities before recording intent or deleting the source. Stopped Start checks each file's immutable bindings before authenticated repair, requires a fresh stopped-container inspection, and checks full consistency before staging. The new regression cases cover these paths; this follow-up was code-only, and I did not independently rerun the reported local tests.

Required repository E2E has been enabled. The focused live driver test does not qualify the full gateway/supervisor path.

Action required: @senthilr-nv, provide the remaining full gateway/supervisor Docker qualification evidence for authenticated workload use, session recovery across image replacement/restart, and end-to-end removal before merge.

Blocking findings: No blocking code findings remain.

Carried findings: None; GATOR-8b9da399-01 and GATOR-8b9da399-02 are fixed.

Gator metadata
  • Validation: Implements accepted Docker lifecycle/storage issue feat(docker): support workload image updates preserving sandbox identity and data #5484.
  • Docs: Published Docker configuration/runtime docs and related skills updated.
  • Head SHA: fc1ce9dbdff2df64894094f63e7d53f0dae4eb91
  • Base SHA: e8ba30fdeff5f9bcc985b2c11064f0b0deb3c168
  • Merge base SHA: e8ba30fdeff5f9bcc985b2c11064f0b0deb3c168
  • Patch ID: 38021007921efd766225245a0ec481ae27e2add6
  • Gator payload: 13
  • Review mode: follow_up
  • Previous reviewed SHA: 8b9da3993e232e484313adc2158d87284381bd9a
  • Review budget exhausted: no
  • Maintainer decision required: no
  • Checks: Branch Checks pending; Helm Lint, Trivy Changes and DCO passed. No approval handoff while required checks or full qualification are outstanding.
  • E2E: test:e2e applied; followed E2E Label Help and reran current-head Branch E2E Checks run 43994841697. Attempt 2 is in progress with build/test prerequisites queued. This supersedes the skipped runtime lanes from attempt 1.
  • Next state: gator:watch-pipeline

@johntmyers johntmyers added gator:watch-pipeline Gator is monitoring PR CI/CD status and removed gator:in-review Gator is reviewing or awaiting PR review feedback labels Nov 17, 2026
Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
@github-actions

Copy link
Copy Markdown

Compatibility review (advisory)

New or updated breaking changes; see the full report for all findings.

1. api-behavior — No explicit risk acceptance found

Docker previously preserved caller labels openshell.ai/docker-workspace-storage and openshell.ai/docker-workspace-volume-identity; it now strips them during creation and interprets their presence on existing containers as persistence metadata.

  • Impact: Existing Docker sandboxes carrying either key can fail StartSandbox with FAILED_PRECONDITION after upgrading, even with persist_workspace=false, while new creations silently lose those labels.
  • Action: For v0.1.9, preserve previously accepted template labels and distinguish driver-created persistent workspaces using independently recorded driver-owned state rather than label presence alone.
  • PR: feat(docker): preserve workspace storage during stopped image updates #5617
Review details
  • Execution: complete
  • Candidate: PR #5617 (bc3fd46bf005ea434592b2d7116264730712e814)
  • Baseline: e8ba30fdeff5f9bcc985b2c11064f0b0deb3c168 (e8ba30fdeff5f9bcc985b2c11064f0b0deb3c168)
  • Reviewed: rust-sdk, python-sdk, typescript-sdk, api-behavior, cli, configuration, policy, helm, state

Advisory review; publication gates are unchanged.

Branch check run

@johntmyers

Copy link
Copy Markdown
Collaborator

gator-agent

PR Review Status

Thanks @senthilr-nv. I checked the new Docker-specific persistence labels, legacy-label regressions, owned-gateway wrapper changes and authenticated Docker qualification suite against the previously reviewed head. The independent follow-up review found no new blocking findings. Both earlier findings remain fixed and their threads remain resolved.

The new suite covers authenticated workload access, image replacement, gateway restart, credential-publication repair and deletion. Adding the suite does not establish a successful live run: it requires the documented opt-in wrapper and is not selected by the standard E2E execution matrix. I checked the wrapper's shell syntax; no local Rust or live Docker tests were run in this sandbox.

Action required: @senthilr-nv, provide a successful full gateway/supervisor Docker qualification result with the tested source revisions and input hashes before merge. Required repository checks must also pass on this head.

Blocking findings: No blocking code findings remain.

Carried findings: None; GATOR-8b9da399-01 and GATOR-8b9da399-02 remain resolved.

Gator metadata
  • Validation: Implements accepted Docker lifecycle/storage issue feat(docker): support workload image updates preserving sandbox identity and data #5484.
  • Docs: Existing published Docker configuration/runtime documentation retained; crate, qualification and contributor instructions updated for this delta.
  • Head SHA: 23573c4b3f32f517ee55b9d21d39a398732375a8
  • Base SHA: e8ba30fdeff5f9bcc985b2c11064f0b0deb3c168
  • Merge base SHA: e8ba30fdeff5f9bcc985b2c11064f0b0deb3c168
  • Patch ID: be93eac571f43f78b0fac266b6d368d4baa56b0b
  • Gator payload: 13
  • Review mode: follow_up
  • Previous reviewed SHA: fc1ce9dbdff2df64894094f63e7d53f0dae4eb91
  • Review budget exhausted: no
  • Maintainer decision required: no
  • Checks: Current-head Branch Checks run 44000021121 in progress; Helm Lint, Trivy Changes and DCO passed. No approval handoff while required checks or full Docker qualification are outstanding.
  • E2E: test:e2e already applied. Current-head Branch E2E Checks run 44000021575 attempt 1 is in progress, so no additional dispatch or rerun is needed. Standard E2E is separate from the opt-in docker-updates qualification.
  • Next state: gator:watch-pipeline

@senthilr-nv

Copy link
Copy Markdown
Author

Full Docker gateway/supervisor qualification now passes locally on 23573c4b3. The repeatable suite and instructions are in docker-updates.

Environment: macOS 26.7.1 arm64; Docker 29.8.0; Rust 1.95.0. The owned test gateway used mutual TLS with certificate verification enabled. No existing gateway or Docker Desktop setting was changed.

Verified through the public API and real CLI/SSH:

  • A client without the mTLS identity was rejected; authenticated API and SSH workload execution succeeded on images A and B.
  • A stopped image-only update replaced the native container and image while retaining the sandbox ID, SSH host fingerprint, original workspace volume and synthetic session-record bytes. Start remained a separate action.
  • Authenticated workload access recovered after gateway restart and normal Stop/Start, retaining the same native replacement container and workspace.
  • After deliberately restoring an old descriptor beside a newer bootstrap in the stopped test sandbox, real Start repaired credential publication. API/SSH execution then succeeded, with generation/session/evidence consistent again.
  • Public API deletion completed and removed the native workload, all four sandbox-owned volumes and private runtime state. A separate read-only audit before wrapper cleanup confirmed zero remaining private boundary files; no credential files or raw runtime state were exported.

Command: OPENSHELL_E2E_DOCKER_IMAGE_UPDATES=1 bash e2e/with-docker-gateway.sh cargo test --locked --manifest-path tests/suites/features/Cargo.toml -p docker-updates -- --nocapture, with the prepared A/B images and runtime/binary overrides documented in the suite README. On this Mac, the isolated fixture used the documented bridge mode because Docker host networking could not reach host loopback. Result: 1 passed, 0 failed, 0 ignored.

Build provenance: gateway and CLI were rebuilt from 23573c4b3. Linux arm64 sandbox/supervisor binaries came from exact-source CI run 43994841697, attempt 2 at fc1ce9dbd; no runtime/shared Rust source, proto, root dependency or toolchain inputs changed between those revisions.

Component Binary SHA-256
Gateway 134375afd3a8f3f7c81d9e1c382d45a8bec0d6cd12041ab514e3a247e9bc7169
CLI aab1376c1d0a20e2cafcbcad09c823eceb60386831c5b704227b9e96be8be25a
Sandbox 59a670ee819593928f4211f09a8136cfc17d2582ae12e3c7526b27e2c04b6241
Supervisor 2a79f447d0cfd1fdfca28b172391b63cbb41e127d4801e04edc6e7f1a523fa5a

The compatibility advisory is also addressed in 23573c4b3: Docker persistence uses dedicated openshell.ai/docker-workspace-* keys, preserving the older generic caller labels and avoiding their reinterpretation on existing containers. Both regressions failed before the fix and pass now. Full driver validation: 186 passed / 3 opt-in tests ignored, plus the separately executed live driver test; driver/gateway/test-suite clippy, formatting and docs checks passed.

The final source is signed and DCO passed. Required Branch Checks and enabled repository E2E are still pending on this head; this local evidence does not waive them. Please review the compatibility delta and full qualification evidence before approval/merge.

@senthilr-nv

Copy link
Copy Markdown
Author

Compatibility follow-up: the latest advisory is valid. Renaming the persistence labels in 23573c4b3 preserves the original generic keys but does not protect legacy callers that used the new spellings. The successful full-path qualification above remains valid for that revision; it does not close this compatibility issue.

I am moving persistence authority to a protected per-sandbox driver record, bound into the private runtime descriptor, while preserving all template labels. The follow-up will also gate volume admission and deletion on that record. Please hold merge until the fix, regression tests and repeated full qualification are posted. The current CI runs can continue.

Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
@johntmyers johntmyers added gator:in-review Gator is reviewing or awaiting PR review feedback and removed gator:watch-pipeline Gator is monitoring PR CI/CD status labels Nov 17, 2026
@senthilr-nv

senthilr-nv commented Nov 17, 2026 •

Copy link
Copy Markdown
Author

The compatibility follow-up is implemented and qualified in signed, DCO-signed-off commit 0acdea553. This supersedes my earlier statement that renaming persistence labels was sufficient.

Storage authority now comes from independent protected driver state. workspace-storage.json records namespace, sandbox, workload UID/GID and exact volume identity, and is bound into both the private bootstrap and runtime descriptor. Generic and Docker-specific workspace label names remain caller data and are preserved. Labels cannot select persistent storage, bypass external volume admission, authorize image replacement, or authorize workspace deletion. Missing/invalid/mismatched records fail closed; replay checks the record before mutation. Failed creation retains recorded ownership until explicit deletion.

Validation on this head:

  • Driver library: 190 passed, 0 failed, 3 opt-in tests ignored. Regressions cover caller label preservation with persistence enabled/disabled, legacy label admission, unrecorded removal, missing/corrupt/foreign records, replay before mutation, and failed-create ownership retention.
  • Separate live Docker driver test: 1 passed, 0 failed; incompatible numeric/symbolic target identity refusal, stopped A→B replacement, retained bytes, replay, and recovery after source deletion.
  • Full real gateway/supervisor Docker qualification suite: 1 passed, 0 failed, 0 ignored in 7.47 seconds, with all components from this exact commit. Verified mTLS rejection without identity; authenticated SDK/SSH execution on A/B; retained sandbox ID, SSH fingerprint, original volume and synthetic session record; authenticated access after image replacement, gateway restart and Stop/Start; and real Start repairing interrupted credential publication.
  • Public API deletion removed the native workload, all four owned volumes and the entire private sandbox directory. An additional audit before wrapper cleanup found zero remaining private boundary files. No credentials or raw runtime state were exported.
  • Driver, Docker-only gateway and focused suite clippy passed with warnings denied; root/feature-workspace formatting and git diff --check passed.

Command: OPENSHELL_E2E_DOCKER_IMAGE_UPDATES=1 bash e2e/with-docker-gateway.sh cargo test --locked --manifest-path tests/suites/features/Cargo.toml -p docker-updates -- --nocapture, with explicit prepared A/B images and runtime/binary overrides documented in the suite. Environment: macOS 26.7.1 arm64, Docker 29.8.0, Rust 1.95.0. The disposable test gateway used bridge mode on this Mac; no existing gateway or Docker setting changed.

Provenance: gateway, CLI, sandbox and supervisor all come from signed head 0acdea55316c88030f415c6d038b9de1be479c85. Gateway/CLI were built natively from this head. Linux arm64 sandbox/supervisor binaries came from this head’s CI run 44005058200, attempt 1, artifacts 14293992856 and 14294835823; their API metadata confirms the exact source SHA. They were packaged locally with the unchanged official runtime Dockerfiles. The fully matching-source run above supersedes the earlier run that reused unchanged-runtime artifacts from fc1ce9dbd.

Binary SHA-256
Gateway 0b4fdbfe8198b62fb37c3a8606992d50133a00a857414b407eebb8d66dfc5339
CLI 0a0690aff14f3b0a94fdd40c08fd328d7b1c5c9482b31ae44e10f10e13000f3a
Sandbox bdc8bf3782c461478ff59ac1b077a3767fbd9ce0c6e626e268c2e09e49e48a8c
Supervisor 75677821828be2bd8fc6f82bd1808ebe3c2a4f60effa55d607e135f1969f4a12

The final-head compatibility assessment is complete: no unaddressed breaks, zero findings, all nine required surfaces reviewed. It names source 0acdea553 and tree cafb27da563f6271dd9ab45a2c5b8d7730794484.

GitHub verifies all eight contribution signatures; DCO and accepted-issue checks passed. Final-head Branch Checks and Branch E2E Checks both passed, attempt 1. Both embedded/external Docker conformance and the Kubernetes/k3s-ha conformance lanes passed. The prior head's Kubernetes k3s-ha workspace test passed its functional assertions but failed API-delete cleanup after a 120-second timeout; that run is not a pass. The required final-head run is now green; the earlier failure is retained as historical evidence. The review follow-up reports no blocking obligations remaining. Final maintainer handoff/approval remains; no merge has been performed.

@johntmyers

Copy link
Copy Markdown
Collaborator

gator-agent

PR Review Status

Thanks @senthilr-nv. I checked your protected storage-authority delta and current-head Docker qualification evidence. Workspace labels now remain caller data; the private ownership record governs admission, update replay and removal. The independent critical-only follow-up found no new Critical defects. Both earlier findings remain fixed and their threads remain resolved.

The qualification suite covers authenticated API/SSH use, retained workspace and SSH identity through image replacement and gateway restart, interrupted credential-publication repair, and API deletion. GitHub artifact metadata confirms that the cited sandbox and supervisor binaries came from this exact head. I inspected the suite and provenance; I did not independently rerun the reported live qualification.

No blocking review obligations remain. Required Branch Checks and repository E2E are still running; Gator will inspect their results before a maintainer handoff.

Carried findings: None; GATOR-8b9da399-01 and GATOR-8b9da399-02 remain resolved.

Gator metadata
  • Validation: Implements accepted Docker lifecycle/storage issue feat(docker): support workload image updates preserving sandbox identity and data #5484.
  • Docs: Published Docker configuration, runtime and sandbox update documentation retained; crate and troubleshooting instructions updated for protected ownership state.
  • Checks: Current-head Branch Checks pending; Helm Lint, Trivy Changes, DCO and issue acceptance passed.
  • E2E: test:e2e already applied; current-head Branch E2E Checks run 44005058200 attempt 1 is in progress with runtime lanes executing. No additional dispatch or rerun required. Reported exact-head local docker-updates qualification passed; it does not waive required repository CI.
  • Head SHA: 0acdea55316c88030f415c6d038b9de1be479c85
  • Base SHA: e8ba30fdeff5f9bcc985b2c11064f0b0deb3c168
  • Merge base SHA: e8ba30fdeff5f9bcc985b2c11064f0b0deb3c168
  • Patch ID: df931633fbdeea2352f249fe7b1db71aadb006d9
  • Gator payload: 13
  • Review mode: critical_only
  • Previous reviewed SHA: 23573c4b3f32f517ee55b9d21d39a398732375a8
  • Review budget exhausted: yes; authoritative ledger requires critical-only review.
  • Maintainer decision required: no; prior obligations resolved, no new Critical, no new subsystem or expanded public configuration/policy surface, and no proposed Warning requiring authorization.
  • Next state: gator:watch-pipeline

@johntmyers johntmyers removed the gator:in-review Gator is reviewing or awaiting PR review feedback label Nov 17, 2026
@johntmyers johntmyers added gator:watch-pipeline Gator is monitoring PR CI/CD status gator:approval-needed Gator completed review; maintainer approval needed and removed gator:watch-pipeline Gator is monitoring PR CI/CD status labels Nov 17, 2026
@senthilr-nv

Copy link
Copy Markdown
Author

@johntmyers Both required runs are now green on 0acdea553: Branch Checks and Branch E2E Checks, attempt 1. Both Docker conformance lanes and Kubernetes/k3s-ha conformance passed; the earlier cleanup timeout did not recur. The PR checklist and exact-head Docker qualification evidence are updated. Your follow-up records no blocking obligations remaining; ready for the pipeline inspection and final maintainer handoff. No additional dispatch or source change was needed.

@johntmyers
johntmyers enabled auto-merge November 17, 2026 23:06
@johntmyers
johntmyers added this pull request to the merge queue Nov 17, 2026
@johntmyers johntmyers added gator:merge-ready and removed gator:approval-needed Gator completed review; maintainer approval needed labels Nov 17, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gator:merge-ready state:accepted A maintainer decided OpenShell should pursue this issue test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(docker): support workload image updates preserving sandbox identity and data

2 participants