Repository navigation
build(windows): link static CRT and Z3 in Windows packages - #5654
shailendra-nv wants to merge 8 commits into
Conversation
Signed-off-by: shailendras <shailendras@nvidia.com>
|
/windows-ci |
|
🌿 Preview your docs: https://nvidia-preview-pr-5654.docs.buildwithfern.com/openshell |
|
/ok to test bb8c4f9 |
Windows ARM64 CI: ✅ passedCommit
|
Compatibility review (advisory)Unaddressed breaking changes Windows remote-test invocations using 1. cli — NOT ACKED
2. configuration — NOT ACKED
Review details
Advisory review; publication gates are unchanged. |
Signed-off-by: shailendras <shailendras@nvidia.com>
|
/ok to test ed4d29d |
|
/windows-ci |
Signed-off-by: shailendras <shailendras@nvidia.com>
|
/ok to test 7200fce |
|
/windows-ci |
Compatibility review (advisory)Unaddressed breaking changes Existing Windows MXC automation using 1. cli — NOT ACKED
2. configuration — NOT ACKED
Review details
Advisory review; publication gates are unchanged. |
Signed-off-by: shailendras <shailendras@nvidia.com>
|
/ok to test 27de545 |
|
/windows-ci |
|
Addressed the compatibility review in 27de545:
The static-only package contract implements the requested removal of the Z3 DLL and Visual C++ redistributable requirements. The real MXC suite passed all seven default scenarios plus HTTPS CA, with zero skips, before this argument/documentation-only follow-up. Windows CI is being refreshed for the new head. |
Compatibility review (advisory)Unaddressed breaking changes The documented Windows Z3 override no longer selects shared Z3, so existing offline or CMake-free build automation can fail. SDKs, runtime APIs, CLI, Helm, policy, and persisted state are unchanged. 1. configuration — ACKED
Review details
Advisory review; publication gates are unchanged. |
|
The latest review confirms that Baseline context:
The package-construction change is intentional: embedding CRT and Z3 removes the destination machine's redistributable and Z3-DLL requirements. |
Signed-off-by: shailendras <shailendras@nvidia.com>
Signed-off-by: shailendras <shailendras@nvidia.com>
|
/ok to test 10b5a55 |
Signed-off-by: shailendras <shailendras@nvidia.com>
|
/ok to test 5a3ff56 |
|
/windows-ci |
Compatibility review (advisory)Unaddressed breaking changes Windows 1. configuration — ACKED
Review details
Advisory review; publication gates are unchanged. |
Signed-off-by: shailendras <shailendras@nvidia.com>
|
/ok to test 7fa8a77 |
|
/windows-ci |
Compatibility review (advisory)Unaddressed breaking changes Windows 1. configuration — ACKED
Review details
Advisory review; publication gates are unchanged. |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Build all four Windows OpenShell executables with the static CRT and embed Z3 in the gateway. The ZIP packages no longer require
libz3.dllor the Visual C++ redistributable for these executables. Preserve Z3 5.1.0 so this changes linkage without upgrading the solver.Related Issue
Closes #5653
The author has verified
MAINTAINaccess to NVIDIA/OpenShell; the issue does not have an acceptance label.Changes
crt-staticto x64 and ARM64 MSVC targets. By default, compile checksum-pinned Z3 5.1.0 source through the existing vendored feature with/MT; alternatively, accept a target-compatible prebuilt staticlibz3.liband matching headers throughZ3_LIBRARY_PATH_OVERRIDE/Z3_SYS_Z3_HEADER, bypassing Z3 source compilation.-Z3DllPathargument for existing command lines.The static-only package contract intentionally changes the contributor build configuration:
Z3_LIBRARY_PATH_OVERRIDEcan no longer select shared Z3 for these packages. Overrides containinglibz3.dllfall back to pinned source with a warning. Cold source builds require CMake, Ninja, and a C++ compiler. Offline builds can setZ3_SRC_SOURCE_DIRto Z3 5.1.0; custom libraries must be rebuilt as static libraries with/MT.CONTRIBUTING.mddocuments these migration settings. The compatibility bot marks this acknowledged migration as an advisory finding; the installed CLI, SDKs, policy, and persisted-state contracts are unchanged. Updating the embedded CRT or Z3 requires rebuilding the packages. MXC retains its separate prerequisites.Size impact
Measured on N1x-Test ARM64, comparing base
28de5674with final head7fa8a776, using the same OpenShell Rust/MSVC toolchain. The baseline uses its original prebuilt Z3 5.1.0 DLL. Both official-style ZIPs were generated with the same external CI packaging script; baseline payload includes the DLL and the static payload contains only the four executables.The two ZIPs together grow by 62,513 bytes (about 61 KiB).
Testing
/MTARM64 Z3 archive and headers to a separate override directory, setZ3_SRC_SOURCE_DIRto a nonexistent directory, and successfully rebuilt all four release executables. All PE audits and isolated--versionsmokes pass; the native Z3 archive was not rebuilt.iso_lifecycle_round_tripconditionally skips because the optional isolation-session backend is unavailable).--versionfrom an otherwise empty package directory; the exact external CI ZIP packager extracts both archives and smoke-tests every executable without shipping any DLL./windows-ci: complete pipeline passes, including native ARM64 check, release build, all four PE audits, all 6,662 workspace tests (43 skips; no flaky retries reported), unsupported-driver/feature-matrix tests, and both ZIP extraction/version smoke tests. Artifacts were uploaded without a Z3 DLL.Passing these checks does not qualify the existing unverified MXC enforcement guarantees.
Checklist