Repository navigation
test(e2e): port provider tests from e2e/rust to testkit - #5657
Draft
matthewgrossman wants to merge 6 commits into
Draft
matthewgrossman wants to merge 6 commits into
matthewgrossman wants to merge 6 commits into
Conversation
create_provider and install_provider return a builder that creates the provider when awaited, so tests can chain .config(key, value) for provider create --config. Existing callers are unchanged. Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Move provider_files and provider_auto_create from e2e/rust into a providers conformance suite. The auto-create test imports a run-unique profile instead of relying on a globally imported claude-code profile, so it no longer changes shared gateway state. Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Requests go to the gateway's endpoint with the service URL's host as the Host header, which is how the gateway routes service traffic. Over TLS the client trusts the gateway CA and presents the registered gateway's client certificate, through openshell-crypto's rustls configuration. Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
… suite Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Member
Author
|
/ok to test b70615f |
|
Label |
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
…mage Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Member
Author
|
/ok to test c7af9e2 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port the provider tests from
e2e/rustto testkit and delete the legacy files. The provider files and auto-create tests join the conformance suite. The service bearer passthrough test moves to a newfeatures/service-exposuresuite.Related Issue
Closes #5656
Part of #5281
Changes
create_providerandinstall_providerreturn aProviderBuilder. Chain.config(key, value)to pass--config; existing calls are unchanged.cx.service_get(url, headers)requests an exposed sandbox service through the gateway endpoint, with the service URL's authority asHost. It uses the gateway's mTLS bundle when the gateway has one, so tmachine environments need no extra routing.providers.rsportsprovider_file_open_update_and_detachandauto_created_provider_credential_available_in_sandbox.service-exposurepackage withbearer_passthrough_preserves_authorization_header, plus rows in.github/workflows/e2e-suites.yml.provider_files.rs,provider_auto_create.rs,service_bearer_passthrough.rs, their[[test]]entries, theprovider_auto_createentry intests/tmachine/artifacts.nix, and the now-unusedrustlsandtokio-rustlse2e dependencies.Differences from the legacy tests
provider_filesran on Docker only, and tmachine lanes skippedprovider_auto_create. Service exposure runs on deb docker, rpm podman (rootful and rootless), k3s, and k3s-ha. Legacy ran it on Docker only.providers/*.yamlglobally and usedclaude-code. The port imports its own run-unique profile and passes the credential through the CLI environment. That removes the global import that deferred this move in test(conformance): migrate workspace, upload, and template e2e tests #4246./run/openshell/providers/<provider>/client.toml.Testing
cargo fmt --checkandcargo clippy -D warningsfor testkit, conformance, features, ande2e/rustservicetestsfeatures/service-exposurerows, and the legacy docker and podman lanes pass in Branch E2E Checks.Checklist