Skip to content

feat(helm): support IPv6 listen addresses for the gateway and shared supervisor - #5669

Open
FrostGod wants to merge 1 commit into
mainfrom
feat/5597-helm-ipv6-listen-address/FrostGod
Open

FrostGod wants to merge 1 commit into
mainfrom
feat/5597-helm-ipv6-listen-address/FrostGod

Conversation

@FrostGod

Copy link
Copy Markdown
Collaborator

Summary

Add gateway.listenAddress and supervisor.listenAddress so the gateway and shared supervisor can listen on IPv6. Both default to 0.0.0.0.

Related Issue

Closes #5597

Changes

  • New values gateway.listenAddress and supervisor.listenAddress.
  • IPv6 hosts render bracketed, for example :: becomes [::]:8080.
  • Applies to the gateway API, health, and metrics listeners, and the shared supervisor health, runtime, and app listeners.

Release Notes

Set gateway.listenAddress and supervisor.listenAddress to :: to run the gateway and shared supervisor on IPv6 clusters.

Testing

  • mise run helm:test, mise run helm:lint, and mise run helm:docs:check pass
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Deployed on a dual-stack, IPv6-primary kind cluster with both values set to ::: the gateway and shared supervisor became Ready, and sandbox create and exec succeeded.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

…supervisor

Add gateway.listenAddress and supervisor.listenAddress, defaulting to
0.0.0.0. Setting :: renders bracketed addresses such as [::]:8080.

Closes #5597

Signed-off-by: divesh <dgude@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 17, 2026
@FrostGod
FrostGod requested a review from TaylorMutch November 17, 2026 22:21
@FrostGod

Copy link
Copy Markdown
Collaborator Author

/ok to test 3cbffbf

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Compatibility review (advisory)

New or updated breaking changes; see the full report for all findings.

1. helm — No explicit risk acceptance found

Helm upgrades with --reuse-values previously needed no listener-address keys but now require gateway.listenAddress and, for shared supervisors, supervisor.listenAddress.

  • Impact: Existing releases retain baseline values without these keys, causing documented helm upgrade --reuse-values workflows to fail during template rendering because openshell.listenHost passes a missing value to contains.
  • Action: Preserve the no-break policy by defaulting missing listener values to 0.0.0.0 inside the templates, and document --reset-then-reuse-values or explicitly setting both listener values as upgrade workarounds.
  • PR: feat(helm): support IPv6 listen addresses for the gateway and shared supervisor #5669
Review details
  • Execution: complete
  • Candidate: PR #5669 (95447bac138883b2d4bbe233435e0241bc5044cc)
  • Baseline: d66d33844373d66ec0ad0ca63e5cea5a6112ad75 (d66d33844373d66ec0ad0ca63e5cea5a6112ad75)
  • Reviewed: rust-sdk, python-sdk, typescript-sdk, api-behavior, cli, configuration, policy, helm, state

Advisory review; publication gates are unchanged.

Branch check run

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:accepted A maintainer decided OpenShell should pursue this issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(helm): support IPv6 listen addresses for the gateway and shared supervisor

1 participant