Repository navigation
feat(helm)!: require opt-in for gateway service routing - #5672
Draft
TaylorMutch wants to merge 1 commit into
Draft
TaylorMutch wants to merge 1 commit into
TaylorMutch wants to merge 1 commit into
Conversation
BREAKING CHANGE: Helm installations relying on gateway service URLs must explicitly set gatewayConfig."openshell.gateway".service_routing_enabled to true before upgrading. Core and non-Kubernetes defaults remain unchanged. Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-5672.docs.buildwithfern.com/openshell |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Default Kubernetes Helm deployments to disabling gateway-mediated sandbox service routing, avoiding an unintended alternate application access path when operators use dedicated application ingress. The core runtime keeps its enabled default, preserving Docker, Podman, and VM behavior outside this chart.
Upgrade action: Helm installations relying on gateway service URLs must explicitly retain forwarding:
Based on #4956. This draft changes Helm behavior separately from the URL and gateway application-auth PRs.
Related Issue
Closes #5671.
Changes
service_routing_enabled = falseby default, including saved values that omit the setting or set it to null; preserve explicit boolean choices.Testing
mise run helm:test: chart unit suites, rendered TOML loader validation, object ownership, resource coherence, supervisor scaling, and autoscaling checks.mise run helm:docs:checkandmise run markdown:lint.Release Notes
Kubernetes Helm deployments now require an explicit opt-in for gateway-mediated sandbox service URLs and HTTP/WebSocket forwarding. Set
gatewayConfig."openshell.gateway".service_routing_enabled: truebefore upgrading if you rely on that path. The core and non-Kubernetes defaults are unchanged.