Repository navigation
Conversation
The chart renders OPENSHELL_PEER_ENDPOINT from an unbracketed pod IP, which is not a valid URI on IPv6 clusters. Closes #5673 Signed-off-by: divesh <dgude@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bracket an IPv6 host in
OPENSHELL_PEER_ENDPOINTso gateway replicas can reach each other on IPv6 clusters. The chart rendershttp://fd00::5:8080, which is not a valid URI; the gateway now useshttp://[fd00::5]:8080.Related Issue
Closes #5673
Changes
OPENSHELL_PEER_ENDPOINT. IPv4, hostname, and already-bracketed endpoints are unchanged.Testing
cargo test -p openshell-server --lib peer_endpoint,cargo fmt, andcargo clippy -p openshell-server --all-targets -- -D warningspassDeployed two gateway replicas on an IPv6-only kind cluster: exec through either replica succeeded, and the peer endpoints logged as
http://[fd00:10:244::a]:8080.Checklist