Skip to content

fix(server): bracket IPv6 pod IPs in the gateway peer endpoint - #5674

Open
FrostGod wants to merge 1 commit into
mainfrom
fix/5673-ha-peer-ipv6-url/FrostGod
Open

FrostGod wants to merge 1 commit into
mainfrom
fix/5673-ha-peer-ipv6-url/FrostGod

Conversation

@FrostGod

Copy link
Copy Markdown
Collaborator

Summary

Bracket an IPv6 host in OPENSHELL_PEER_ENDPOINT so gateway replicas can reach each other on IPv6 clusters. The chart renders http://fd00::5:8080, which is not a valid URI; the gateway now uses http://[fd00::5]:8080.

Related Issue

Closes #5673

Changes

  • Bracket an unbracketed IPv6 host when reading OPENSHELL_PEER_ENDPOINT. IPv4, hostname, and already-bracketed endpoints are unchanged.

Testing

  • cargo test -p openshell-server --lib peer_endpoint, cargo fmt, and cargo clippy -p openshell-server --all-targets -- -D warnings pass
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Deployed two gateway replicas on an IPv6-only kind cluster: exec through either replica succeeded, and the peer endpoints logged as http://[fd00:10:244::a]:8080.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

The chart renders OPENSHELL_PEER_ENDPOINT from an unbracketed pod IP,
which is not a valid URI on IPv6 clusters.

Closes #5673

Signed-off-by: divesh <dgude@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:accepted A maintainer decided OpenShell should pursue this issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(server): bracket IPv6 pod IPs in the gateway peer endpoint

1 participant