Repository navigation
Conversation
Allow a terminal /** in path_template so one path-placed credential serves multiple API methods while preserving exact templates and endpoint authorization. Keep the credential slot anchored and reject duplicate, misplaced, and traversal-bearing references. Cover long-polling getUpdates alongside sendMessage using one HTTP client and one credential through the production REST relay. Update provider documentation and CLI guidance. Closes NVIDIA#5544 Signed-off-by: Luomu <enrondg@gmail.com>
|
All contributors have signed the DCO ✍️ ✅ |
Author
|
I have read the DCO document and I hereby sign the DCO. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow a terminal
/**in a credential'spath_templateso a bot can use one token forgetUpdates,sendMessage, and other API methods. Templates without that suffix retain exact matching, and the credential must remain in its declared path slot.Related Issue
Closes #5544
Changes
/**suffix.getUpdatespending, completesendMessagewith the same credential, and only then release the polling response./bot{credential}/**example.Release Notes
Testing
Validation:
Rust checks use the repository-pinned Rust 1.95.0 toolchain with default features:
cargo fmt -p openshell-core -p openshell-supervisor-network -- --check— passed.cargo clippy --locked -p openshell-core -p openshell-supervisor-network --all-targets -- -D warnings— passed.cargo test --locked -p openshell-core -p openshell-supervisor-network --lib— 2,378 passed, 2 ignored (655 core tests and 1,723 network tests).npx --yes markdownlint-cli2@0.22.0 docs/how-it-works/providers/overview.mdx docs/how-it-works/providers/profiles.mdx skills/openshell-cli/SKILL.md— passed before rebasing, 0 errors. The documentation edits were unchanged by the rebase; a rerun was unavailable in this environment.uv run tasks/scripts/check_docs_nav.py— passed.The concurrent test uses a shared HTTP client and production request parsing, credential resolution, body forwarding, and response relay against a loopback Bot API fixture. Live Telegram SDK/API and sandbox E2E tests were not run. Fern strict validation was not run in this environment.
Checklist