Repository navigation
Conversation
Transparent egress to an IPv6 destination built an unbracketed authority that parse_target rejects, so the connection was closed. Closes #5693 Signed-off-by: divesh <dgude@nvidia.com>
Collaborator
Author
|
/ok to test 8cec7fe |
3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Transparent egress to an allowed IPv6 address was closed with no response. The internal CONNECT authority was built as
fd00::5:8081, whichparse_targetrejects; it is now[fd00::5]:8081.Related Issue
Closes #5693
Changes
SocketAddrfor IP hosts, so IPv6 is bracketed. Hostnames and IPv4 are unchanged.Testing
cargo test -p openshell-supervisor-network --lib -- transparent_connect_authority parse_target,cargo fmt, andcargo clippy -p openshell-supervisor-network --all-targets -- -D warningspassOn an IPv6-only kind cluster, a sandbox request to an IPv6 Service IP allowed by
allowed_ipsnow succeeds; onmainit was closed with no response.Checklist