Skip to content

fix(reconstruction): recognize backtick identifier lists - #1073

Merged
rng1995 merged 1 commit into
NVIDIA:mainfrom
anuragbanerjee:fix/markdown-identifier-lists
Nov 9, 2026
Merged

rng1995 merged 1 commit into
NVIDIA:mainfrom
anuragbanerjee:fix/markdown-identifier-lists

Conversation

@anuragbanerjee

@anuragbanerjee anuragbanerjee commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Backtick-quoted identifiers such as biome-ignore followed by another quoted identifier are misread as removal instructions. The fallback parser treats the closing backtick as a marker opener and reconstructs the intervening comma and space.

Changes

Extend the existing quoted-string-sequence guard to bounded backtick identifier prefixes. Preserve immediate openers, including quoted multiword verbs, and leave filler-bearing and explicit removal instructions detectable.

Test plan

  • Validation on 16d8be119763483365c16cfb3a45127b9c24ab14, macOS, Python 3.13.13, in a fresh environment installed with uv sync --all-extras --locked and an isolated home without provider credentials.
  • make format: passed; all 365 files unchanged.
  • make lint and make format-check: passed across src/ and tests/.
  • make test: exit 0. Unit phase: 20,958 passed, 57 skipped, 4 xfailed (258 deselected). Integration phase: 249 passed, 5 skipped (21,023 deselected). Skips and expected failures are not counted as passes; live-provider validation is not claimed.
  • A diagnostic integration rerun with -rs confirmed the five skips are optional live CLI tests: three require claude, two require gemini; neither binary is on the isolated test PATH. It again passed 249 tests.
  • Reproduced two failing identifier-list cases on upstream main e48d771a before the fix. The focused reconstruction/documentation suite passed all 1,264 tests after the fix.
  • Added controls for quoted multiword verbs, explicit/passive/replacement directives, a real directive following an identifier list, and backtick filler.
  • Two independent local reviews found no remaining blockers after correcting the multiword-verb regression.

Task

Related to the existing false-positive reports #868 and #515.

Risk and rollback

This changes one existing reconstruction heuristic. The additional recognition is bounded, restricted to identifier characters, and requires the existing following quoted-item check. Revert this commit to restore prior behavior.

Notes

This is separate from TypeScript template ownership in #990 and does not change policy, suppress findings, or add a language parser. On a local full-skill fixture it cleared the Markdown partial-analysis result; unrelated TypeScript partial analysis remained. No private skill contents are included.

Checked against CONTRIBUTING.md: the contribution uses a fork branch, references existing issues, includes regression tests, runs the documented formatting/lint/full-test targets, and the sole commit carries the required DCO sign-off. Existing SPDX headers are preserved; no new source files were added. The repository has no PR template, so this description retains summary, changes, validation, issue references, risk/rollback, and scope notes.

Signed-off-by: AJ Banerjee <anuragb2010@gmail.com>
@anuragbanerjee
anuragbanerjee force-pushed the fix/markdown-identifier-lists branch from aca581d to 16d8be1 Compare November 9, 2026 07:45

@rng1995 rng1995 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[SkillSpector Review]
Approve at 16d8be119763483365c16cfb3a45127b9c24ab14.

Value and readiness: The change addresses the documentation false positives described in #868/#515: the closing backtick in an identifier such as biome-ignore must not open a removal marker. The additional backward lookup is bounded by MAX_DIRECTIVE_HEADER_CHARS, accepts only identifier characters, and retains the existing following-quoted-item check. Immediate openers preserve multiword quoted verbs; filler-bearing and explicit/passive/replacement directives retain their existing paths. The new positive and negative controls cover these distinctions. Ready from this review.

Material findings: None.

PIC tradeoffs: None.

Verification and gaps: Reviewed the complete two-file diff, surrounding exact-head reconstruction logic, added tests, both linked issues, and cutoff discussion/review/thread history (empty). Hosted CI run 42581353973 is attributed to this exact head; its test-unit log reports 20,991 passed, 24 skipped, 258 deselected and 4 xfailed, with the reconstruction test module included. The six reported CI checks succeeded. This was a static review; no contributor code, tests, imports, builds or setup were executed locally. Author-reported local and integration results were not independently reproduced.

@rng1995
rng1995 merged commit 007487a into NVIDIA:main Nov 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants