Skip to content

feat(report): retain sanitized input acquisition origin - #1118

Merged
rng1995 merged 1 commit into
NVIDIA:mainfrom
chrisknvidia:feat/christopherk/report-input-origin
Nov 19, 2026
Merged

rng1995 merged 1 commit into
NVIDIA:mainfrom
chrisknvidia:feat/christopherk/report-input-origin

Conversation

@chrisknvidia

@chrisknvidia chrisknvidia commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Reports now retain the requested input origin and type alongside the materialized scan directory. JSON adds skill.origin, SARIF adds runs[].properties.inputOrigin, and terminal/Markdown display the same metadata. URL userinfo, queries and fragments are omitted; literal local path spelling is preserved. Existing source fields, finding coordinates and cleanup behavior remain intact.

Validation at c1444826c3db57d11787c93db980094bd50d2e3b:

  • 700 report/resolver/provenance tests pass; formatting and lint pass.
  • 42 actual source and installed-wheel CLI runs cover directory, standalone file, wrapped ZIP, public HTTPS and Git inputs, all four report formats, relative/trailing-space names, URL redaction, cleanup and incomplete/failed scans. Eight actual MCP calls cover full reports and compact responses.
  • Eight SARIF outputs pass the official OASIS 2.1.0 JSON schema. The wheel matches all 159 source package files and 157 frozen runtime distributions.
  • Current-head hosted CI, attempt 1, passes all six checks. The completed unit log records 25,274 passed, 28 skipped, 261 deselected and 4 xfailed; the dedicated dependency-inspection step records 99 passed.

Origin records the sanitized request, not a resolved revision or content digest. Local paths and URL paths remain visible; arbitrary secrets inside those paths are outside this projection. Runtime validation used no-LLM scans on macOS; live-model, Windows and customer-production behavior were not exercised. Schema validation does not establish hosted SARIF ingestion. An optional targeted mypy check retains the same two pre-existing report typing diagnostics reproduced on the base revision.

This additive metadata is separate from multi-format output selection in #1065.

Closes #1116.

Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
@chrisknvidia
chrisknvidia marked this pull request as ready for review November 13, 2026 19:17
@chrisknvidia
chrisknvidia requested a review from rng1995 November 13, 2026 19:18
@chrisknvidia

Copy link
Copy Markdown
Collaborator Author

Ready for review. All six hosted checks pass at c1444826c3db57d11787c93db980094bd50d2e3b, including 25,274 unit tests. The PR description includes source/wheel CLI and MCP validation, output-schema checks and qualification limits.

@rng1995 rng1995 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[SkillSpector Review]

Decision: Approved

Value and readiness

Saved reports can identify the acquisition target after the working directory is removed. The origin remains distinct from finding coordinates and local scan state.

Material findings

No blocking findings. The resolver attaches the origin after materialization, preserving local spelling. Report entry validates the optional state and applies the same URL projection before the four renderers. The test covers userinfo, port, query, fragments, malformed URLs, missing state and local cleanup. SARIF adds the origin in a run property bag.

PIC tradeoffs

The new fields identify the request. They carry literal local paths and URL paths and provide no content digest or resolved Git revision. The MCP outer target still echoes the caller's request, while the embedded report uses the sanitized metadata.

Verification and gaps

Reviewed the complete seven-file diff and exact-head resolver, rendering, model and CLI/MCP entry-point context. All six hosted checks passed at the reviewed SHA. The author reports working source and wheel CLI/MCP runs and OASIS SARIF schema validation. I did not rerun contributor code, tests, network acquisition, or hosted SARIF ingestion.

Reviewed head: c1444826c3db57d11787c93db980094bd50d2e3b.

@rng1995
rng1995 merged commit c8fd126 into NVIDIA:main Nov 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retain the original input origin in saved scan reports

2 participants