Skip to content

fix(deps): bump locked pyasn1, cryptography and pyjwt past published advisories - #1148

Merged
rng1995 merged 1 commit into
NVIDIA:mainfrom
johncgoat:fix/deps-pyasn1-cryptography-pyjwt
Nov 19, 2026
Merged

rng1995 merged 1 commit into
NVIDIA:mainfrom
johncgoat:fix/deps-pyasn1-cryptography-pyjwt

Conversation

@johncgoat

@johncgoat johncgoat commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Closes #1146

uv.lock pinned three packages inside published advisory ranges. This refreshes only those three, following the same lock-only approach as #1095:

uv lock --upgrade-package pyasn1 --upgrade-package cryptography --upgrade-package pyjwt
package before after scope advisories cleared
pyasn1 0.6.4 0.6.5 runtime (google-auth -> pyasn1-modules) CVE-2026-119194, -119195, -119196, -119197
cryptography 49.0.0 50.0.2 runtime (google-auth; also langgraph-api, secretstorage) CVE-2026-69247
pyjwt 2.13.0 2.15.1 [mcp] (mcp -> pyjwt[crypto]) and [langgraph-dev] (langgraph-api) CVE-2026-102268 (critical), CVE-2026-102265/66/67/69/70/71/72/73/74/75, CVE-2026-101917, CVE-2026-101918, GHSA-pxh4-856f-4h89
  • No other locked package changes.
  • The lock revision stays at 5, because I used uv 0.13.9, the same lock revision as main.
  • pyproject.toml is unchanged.
  • A CHANGELOG line is added under 2.12.0 (Unreleased).

Before / after

Vulnerability scan of uv.lock. Trivy fs --scanners vuln, offline DB, same DB for both runs:

CRITICAL HIGH MEDIUM LOW total in pyasn1 / cryptography / pyjwt
main (a09091e) 1 28 29 6 64 20
this branch 0 17 21 6 44 0

Runtime image. I built a uv sync --frozen --no-dev image (python:3.12-slim-bookworm, non-root) from each lockfile and scanned it offline with Trivy. On this branch the image has cryptography 50.0.2 and pyasn1 0.6.5, and no pyasn1 or cryptography findings remain. pyjwt is not installed without extras.

Unit tests. I ran the same command on both sides, back to back: python -m pytest -p no:cacheprovider -q -rfE --continue-on-collection-errors tests (default markers: not integration and not provider). Python 3.12 ran in a python:3.12-slim-bookworm container with --network none and a read-only root filesystem, as an unprivileged user. Dependencies came from uv.lock with --no-dev plus the dev extra:

passed failed errors skipped xfailed
main (a09091e) 25797 126 4 28 4
this branch 25797 126 4 28 4

The failing test IDs are identical on both sides: this branch adds no failures. They all come from the sandbox, not from this change:

  • The build context omits repository files such as docs/, .github/, scripts/, contrib/ and THIRD_PARTY_NOTICES.md. That accounts for the 4 collection errors and the release, docs and license tests.
  • There is no network, so the tiktoken download and offline uv launcher tests fail.
  • git is absent from the image.
  • Several LLM-path and opencode provider tests fail.

Installed versions in the branch environment: pyasn1 0.6.5, cryptography 50.0.2, pyjwt 2.15.1 (with the dev extra).

The verification output above is from local runs.

Notes

  • For --no-llm scans these are low-reachability:
    • pyasn1 is only reached through google-auth credential loading on the Gemini path.
    • SkillSpector never calls PKCS#7 decryption.
    • pyjwt is only installed with the [mcp]/[langgraph-dev]/[dev] extras.
      They are still flagged by every lockfile scanner, and skillspector mcp users install [mcp].
  • One pyjwt advisory (CVE-2026-103001, MEDIUM) had no fixed version in the scanner DB on main. Trivy no longer reports it against 2.15.1.
  • The Docker image on main installs with pip install . and does not consume uv.lock, so this bump reaches Docker users once the image installs from the lock (proposed in Harden LLM prompts against scanned-skill steering; build the image from uv.lock as non-root #817).

🤖 Generated with Claude Code

…advisories

uv.lock pinned three packages inside published advisory ranges:

- pyasn1 0.6.4 (runtime, via google-auth -> pyasn1-modules):
  CVE-2026-119194, CVE-2026-119195, CVE-2026-119196 and
  CVE-2026-119197, fixed in 0.6.5.
- cryptography 49.0.0 (runtime, via google-auth): CVE-2026-69247,
  fixed in 50.0.0.
- pyjwt 2.13.0 (the [mcp] extra via mcp, and the langgraph-dev extra
  via langgraph-api): CVE-2026-102268 (critical) plus related HIGH and
  MEDIUM advisories, fixed in 2.14.0 and 2.15.0.

Refresh only these three with
`uv lock --upgrade-package pyasn1 --upgrade-package cryptography
--upgrade-package pyjwt`: pyasn1 0.6.5, cryptography 50.0.2 and
pyjwt 2.15.1. No other locked package changes and pyproject.toml is
unchanged.

Closes NVIDIA#1146

Signed-off-by: John Campbell <235741223+johncgoat@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@johncgoat
johncgoat force-pushed the fix/deps-pyasn1-cryptography-pyjwt branch from c1ab8bb to d7b4421 Compare November 17, 2026 16:32

@rng1995 rng1995 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[SkillSpector Review]

Decision: Approved

Value and readiness

The lock refresh moves three existing dependencies out of published affected ranges. The scope matches #1146 and is ready for maintainer review.

Material findings

No required changes. The complete diff updates the changelog and the pyasn1, cryptography and PyJWT lock entries. Comparing the parsed base and head lockfiles confirms unchanged dependency edges, extras, registries and lock metadata. The replacements are pyasn1 0.6.5, cryptography 50.0.2 and PyJWT 2.15.1. GitHub's affected ranges for the cited advisories exclude those versions.

PIC tradeoffs

The fix applies to installations that consume the lockfile. Docker and other installations that resolve dependencies independently have their own resolution behavior.

Verification and gaps

Read the complete diff, pinned lockfiles, linked issue, advisory ranges and review history. GitHub reports all six checks successful on the reviewed commit, including unit tests and Docker smoke. The author's local Trivy comparison is supporting evidence and was not rerun. No contributor code or tests were executed locally.

Reviewed head: d7b44217bb329c8648c009ce9f61c787f45cb4f4.

@rng1995
rng1995 merged commit ea1d535 into NVIDIA:main Nov 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uv.lock pins pyasn1 0.6.4, cryptography 49.0.0 and pyjwt 2.13.0 inside published advisory ranges

2 participants