Repository navigation
fix(deps): bump locked pyasn1, cryptography and pyjwt past published advisories - #1148
Conversation
…advisories uv.lock pinned three packages inside published advisory ranges: - pyasn1 0.6.4 (runtime, via google-auth -> pyasn1-modules): CVE-2026-119194, CVE-2026-119195, CVE-2026-119196 and CVE-2026-119197, fixed in 0.6.5. - cryptography 49.0.0 (runtime, via google-auth): CVE-2026-69247, fixed in 50.0.0. - pyjwt 2.13.0 (the [mcp] extra via mcp, and the langgraph-dev extra via langgraph-api): CVE-2026-102268 (critical) plus related HIGH and MEDIUM advisories, fixed in 2.14.0 and 2.15.0. Refresh only these three with `uv lock --upgrade-package pyasn1 --upgrade-package cryptography --upgrade-package pyjwt`: pyasn1 0.6.5, cryptography 50.0.2 and pyjwt 2.15.1. No other locked package changes and pyproject.toml is unchanged. Closes NVIDIA#1146 Signed-off-by: John Campbell <235741223+johncgoat@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
c1ab8bb to
d7b4421
Compare
rng1995
left a comment
There was a problem hiding this comment.
[SkillSpector Review]
Decision: Approved
Value and readiness
The lock refresh moves three existing dependencies out of published affected ranges. The scope matches #1146 and is ready for maintainer review.
Material findings
No required changes. The complete diff updates the changelog and the pyasn1, cryptography and PyJWT lock entries. Comparing the parsed base and head lockfiles confirms unchanged dependency edges, extras, registries and lock metadata. The replacements are pyasn1 0.6.5, cryptography 50.0.2 and PyJWT 2.15.1. GitHub's affected ranges for the cited advisories exclude those versions.
PIC tradeoffs
The fix applies to installations that consume the lockfile. Docker and other installations that resolve dependencies independently have their own resolution behavior.
Verification and gaps
Read the complete diff, pinned lockfiles, linked issue, advisory ranges and review history. GitHub reports all six checks successful on the reviewed commit, including unit tests and Docker smoke. The author's local Trivy comparison is supporting evidence and was not rerun. No contributor code or tests were executed locally.
Reviewed head: d7b44217bb329c8648c009ce9f61c787f45cb4f4.
Summary
Closes #1146
uv.lockpinned three packages inside published advisory ranges. This refreshes only those three, following the same lock-only approach as #1095:[mcp](mcp -> pyjwt[crypto]) and[langgraph-dev](langgraph-api)revisionstays at 5, because I used uv 0.13.9, the same lock revision asmain.pyproject.tomlis unchanged.Before / after
Vulnerability scan of
uv.lock. Trivyfs --scanners vuln, offline DB, same DB for both runs:main(a09091e)Runtime image. I built a
uv sync --frozen --no-devimage (python:3.12-slim-bookworm, non-root) from each lockfile and scanned it offline with Trivy. On this branch the image has cryptography 50.0.2 and pyasn1 0.6.5, and no pyasn1 or cryptography findings remain. pyjwt is not installed without extras.Unit tests. I ran the same command on both sides, back to back:
python -m pytest -p no:cacheprovider -q -rfE --continue-on-collection-errors tests(default markers:not integration and not provider). Python 3.12 ran in apython:3.12-slim-bookwormcontainer with--network noneand a read-only root filesystem, as an unprivileged user. Dependencies came fromuv.lockwith--no-devplus thedevextra:main(a09091e)The failing test IDs are identical on both sides: this branch adds no failures. They all come from the sandbox, not from this change:
docs/,.github/,scripts/,contrib/andTHIRD_PARTY_NOTICES.md. That accounts for the 4 collection errors and the release, docs and license tests.uvlauncher tests fail.gitis absent from the image.Installed versions in the branch environment: pyasn1 0.6.5, cryptography 50.0.2, pyjwt 2.15.1 (with the dev extra).
The verification output above is from local runs.
Notes
--no-llmscans these are low-reachability:[mcp]/[langgraph-dev]/[dev]extras.They are still flagged by every lockfile scanner, and
skillspector mcpusers install[mcp].main. Trivy no longer reports it against 2.15.1.maininstalls withpip install .and does not consumeuv.lock, so this bump reaches Docker users once the image installs from the lock (proposed in Harden LLM prompts against scanned-skill steering; build the image from uv.lock as non-root #817).🤖 Generated with Claude Code