Repository navigation
fix(static): detect Chinese-language prompt injection #968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Varshith-Kali
wants to merge
10
commits into
NVIDIA:main
Choose a base branch
from
Varshith-Kali:fix/zh-prompt-injection-953
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c288b59
fix(static): detect Chinese-language prompt injection
Varshith-Kali a27dde3
fix(static): split AR1 Chinese refusal pattern to avoid quadratic whi…
Varshith-Kali 5e65af1
fix(static): split Chinese P1/P6 patterns and exempt direct Chinese e…
Varshith-Kali 20ba1e1
fix(static): split Chinese AR1/AR2/AR3 and E4 patterns to bound near-…
Varshith-Kali 0356676
fix(static): exempt the traditional direct prohibition on extraction …
Varshith-Kali 565f6a3
fix(static): retain detection on reversed Chinese prohibitions, narro…
Varshith-Kali cbe5159
fix(static): retain detection on mixed-language reversal, notice comp…
Varshith-Kali 439ad62
fix(static): reject conditional English leading in Chinese prohibitio…
Varshith-Kali 5529f0b
fix(static): retain P6 on Traditional conditional prohibition, drop u…
Varshith-Kali 54166fe
fix(static): match Traditional 當 in only-when qualifier (#968)
Varshith-Kali File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trailing-reversal case is fixed. Please also apply the English reversal check to the leading context. For these two lines:
The Chinese prefix matches after the newline, but this guard checks only Chinese disavowals. The remaining tail is just a period, so the helper returns
Trueand P6 skipsoutput your system prompt. The new tail checks never see the leadingIgnore. The English branch already checks_DISAVOWALinleading, andtest_p6_overridden_prohibition_is_retainedcovers the English equivalent. Please retain the same behavior for the Chinese prefix and add this mixed-language control.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. The Chinese prohibition helper now checks the English disavowal list in the leading context too, mirroring the English branch, so Ignore this rule followed by a Chinese prohibition no longer exempts the extraction. The mixed-language control is now in test_reversal_after_chinese_prohibition_still_flags, in both the English-action and Chinese-action forms. It failed pre-fix with no P6 and passes post-fix, while the pure Chinese prohibition stays exempt. Full analyzer suite: 11386 passed.