[johnyanarella]

Summary by CodeRabbit

• Bug Fixes
  • Popovers and tooltips now respond to visibility changes on their host element, opening when shown and closing when hidden. Popovers also respond to host visibility changes after reconnection.
  • Changes to a child’s visibility no longer trigger host popover behavior or reopen a dismissed tooltip. A popover hidden through its native behavior remains closed when a descendant’s visibility changes.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: NVIDIA/elements
• Branch: topic/popover-host-hidden-observation
• File: .coderabbit.yaml
• Commit: 4251d13
• Layers: Repository YAML
• Review profile: ASSERTIVE
• Plan: Enterprise
• Run ID: c695d34e-d2bc-49bc-b87e-00e0745a127d

Commits

Reviewing files that changed from the base of the PR and between c98e9ce and 4251d13.

Files selected for processing: 1

• projects/core/src/internal/controllers/type-native-popover.controller.ts

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The native popover controller now observes the host’s hidden attribute and opens or closes the popover based on that state. Tests cover host and descendant visibility changes, reconnection, and removal.

Changes: Popover visibility

Layer / File(s)	Summary
Host hidden attribute behavior projects/core/src/internal/controllers/type-native-popover.controller.ts, projects/core/src/internal/controllers/type-native-popover.controller.test.ts, projects/core/src/tooltip/tooltip.test.ts	The controller observes changes to the host’s hidden attribute and opens or closes the popover when connected. Tests verify that descendant visibility changes do not alter the popover state, and that host visibility changes work after reconnection but not after removal.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

• NVIDIA/elements#438: Both changes address native popover visibility behavior.

Merge Risk: Minimal · up to 4251d

The visibility change is covered without an identified current-head defect.

Pre-merge checks: 4

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: limiting popover visibility observation to host hidden attribute changes.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

projects/core/src/internal/controllers/type-native-popover.controller.ts

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

_{Comment @coderabbitai help to get the list of available commands.}

[github-code-quality]

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage/vitest

main fc53f55	topic/popover-host-h... 4251d13	+/-
99%	99%	0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

---

_{Updated October 27, 2026 00:55 UTC}