Skip to content

chore(internals): cover starter creation result messages - #468

Merged
coryrylan merged 1 commit into
mainfrom
topic/upkeep/coverage/starter-created
Oct 27, 2026
Merged

coryrylan merged 1 commit into
mainfrom
topic/upkeep/coverage/starter-created

Conversation

@cursor

@cursor cursor Bot commented Oct 27, 2026

Copy link
Copy Markdown

Coverage upkeep for projects/internals/tools/src/project/starters.ts.

The selector chose this file: "7 uncovered lines, 92.04% lines and 87.75% branches, the smallest gap below the 90% threshold."

Measurement

  • Lines: 81/88 (92.04%) → 85/88 (96.59%)
  • Branches: 43/49 (87.75%) → 45/49 (91.83%)
  • Functions: 27/28 (96.42%) → 28/28 (100%)
  • No other file's coverage decreased

API

No public API changed.

Left alone

These defensive or unreachable branches remain. Line and branch coverage are both above 90%, so the file drops out of the coverage rotation:

  • missing pnpm-workspace.yaml throw in findWorkspaceRoot
  • final isRecord check in normalizeAngularConfigForExport
  • missing package version throw in getPackageVersion
  • equal-key arm of the allowBuilds sort
  • empty playwright-lock fallback in removeWireitScripts

Validation

  • projects/internals/tools pnpm run lint passed
  • projects/internals/tools pnpm run test passed (773 tests)
  • projects/internals/tools pnpm run test:coverage passed
  • test:types, test:axe, test:ssr, test:lighthouse, and test:visual are not defined in this project
  • root pnpm run ci passed
  • git diff --check passed
Open in Web View Automation 

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage/vitest

main 576980e topic/upkeep/coverag... a5eab2c +/-
99% 99% 0%
View coverage of the 1 most impacted file.
File main 576980e topic/upkeep/coverag... a5eab2c +/-
projects/intern...ect/starters.ts 92% 97% +5%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated October 27, 2026 13:15 UTC

Adds unit tests for the success log and the optional next-steps
branch in starters.ts, raising line coverage from 92.04% to 96.59%
and branch coverage from 87.75% to 91.83%. No behavior change.

Co-authored-by: Cory Rylan  <coryrylan@users.noreply.github.com>
Signed-off-by: Cursor Agent <cursoragent@cursor.com>
@coryrylan
coryrylan force-pushed the topic/upkeep/coverage/starter-created branch from 0825d58 to a5eab2c Compare October 27, 2026 13:07
@coryrylan
coryrylan enabled auto-merge (rebase) October 27, 2026 13:09
@coryrylan
coryrylan merged commit 0a3974e into main Oct 27, 2026
17 checks passed
@coryrylan
coryrylan deleted the topic/upkeep/coverage/starter-created branch October 27, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants