Skip to content

Account for uncertainty in log #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanmrichard merged 1 commit into from
Sep 1, 2026
Merged

Account for uncertainty in log #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion tests/cxx/unit_tests/tensorwrapper/generate/generate_eigenvalues.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,21 @@ using namespace tensorwrapper::generate;
using namespace tensorwrapper::operations;
using namespace tensorwrapper::utilities;

namespace {
// Composing two transcendental functions (log then exp) forces a rigorous
// Interval to widen by more than the default 1e-16 tolerance even when
// compared against itself, since an interval's difference with itself is not
// zero-width unless the interval is a single point. This tolerance accounts
// for that unavoidable widening.
template<typename T>
constexpr double log_spacing_tol =
std::is_same_v<T, float> || std::is_same_v<T, types::ufloat> ||
std::is_same_v<T, types::ifloat> || std::is_same_v<T, types::afloat> ||
std::is_same_v<T, types::tafloat> || std::is_same_v<T, types::tmfloat> ?
5e-3 :
1e-9;
} // namespace

TEMPLATE_LIST_TEST_CASE("generate_eigenvalues", "",
types::floating_point_types) {
SECTION("n == 1") {
Expand Down Expand Up @@ -70,7 +85,7 @@ TEMPLATE_LIST_TEST_CASE("generate_eigenvalues", "",
auto gen = make_rng(1);
auto result = generate_eigenvalues<TestType>(spec, gen);
auto corr = make_tensor({3}, expected);
REQUIRE(approximately_equal(result, corr));
REQUIRE(approximately_equal(result, corr, log_spacing_tol<TestType>));
}

SECTION("degenerate spacing") {
Expand Down
Loading