Repository navigation
docs: refocus the loader pages on what nf start users need - #125
Merged
Merged
Conversation
Keep what runs where, ports, environment, secure context, cache and troubleshooting. Drop the standalone install and npx usage, which the CLI does for you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
No linked issue: this is a full audit of the loader pages, requested directly. They are cut down to what an
nf start/nf devuser acts on: what runs where, ports, env, HTTPS and the secure context, cache, loading steps, themain()arguments, and troubleshooting. The npx and standalone usage is removed, and the pages link to the CLI pages instead of repeating them. Slugs are unchanged.These pages describe loader
main, including the per-file cache that came after 1.6.0. They go live with the next loader release, which this matches.How do you test this PR?
-d(there is none), focused on npx, and showed a.envname the client never gets.apps/*. The server loader's crash behaviour was reproduced on 1.6.0: it exits even with--watch.mint validate,mint broken-linksandmint a11yon a scratch copy of the site with all four source branches (engine, cli, loader, editor) and the docs redirects synced in: all pass, 83 pages.pnpm exec prettier --checkand the pre-push hook (lint, tests): pass.Merge danger
Door: two-way, docs only: a revert is enough.
Blast radius: the public docs.nanoforge.eu, at this repo's next release (docs-sync), not at merge.
Follow-up issues
To be filed: the server loader exits when the game crashes in
--watchmode; the loading page has<title>Title</title>.Quality gate
reviewer: findings fixed in the last commitmint a11y)style-reviewer: pass