Repository navigation
Rename the org members test's writesSent() so the suite loads again - #119
Merged
Merged
Conversation
OrgMembersTest and OutboxTest each declared a global writesSent(), and Pest loads every test file into one process, so the whole suite stopped on "Cannot redeclare function". The org members one returns method and path, so it's memberWritesSent() now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#100 and #101 both added a global
writesSent()helper to their test files, OutboxTest and OrgMembersTest. Pest loads every test file into one process, so since #100 merged the whole suite stops with "Cannot redeclare function writesSent()" before any test runs. That's why CI on main has been failing.The two helpers return different things. OutboxTest's gives the methods in order, and OrgMembersTest's gives method and path. So I renamed the org members one to
memberWritesSent()and left OutboxTest alone. No other global test helper is declared twice. The full suite passes locally (1423 tests).Screenshots
🤖 Generated with Claude Code