Repository navigation
Conversation
mobile-ui 0.9.0 includes NativePHP/mobile-ui#182, so an Android swipe in a gesture area no longer also presses the pressable under the finger. The 0.75 s window that ignored that press has nothing left to catch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mobile-ui 0.9.0 that main already locks includes NativePHP/mobile-ui#182, so on Android a swipe in a gesture area no longer also presses the pressable under the finger. That extra press is why #102 ignored any tap for 0.75 s after a swipe opened a message's options. With the fix in, the guard has nothing left to catch, so this takes out
Conversation::SwipeTapWindow,$actionsShownAtand the early return inhideActions().The only difference anyone could notice: a tap straight after the swipe now puts the options away. Before, it was ignored for three quarters of a second.
The other mobile-ui workaround, the column inside the photos pressable that held the gap so iOS menu items didn't each add one, is already gone. #126 bumped mobile-ui past NativePHP/mobile-ui#188 before it merged and put
gap-1back on the pressable, so there's nothing to do for it here.Testing
The two
ConversationTesttests that travelled a second past the window now tap straight away. The Screens tests pass (1108).I tried it against a local dev-null.sh at production. On an Android 15 emulator I swiped someone else's long message open three times, letting go with the finger still on the bubble. Each time the options came up and were still there a few seconds later, and a tap on another bubble put them away. A tap right after the swipe closes them as well. On an iPhone 17 Pro simulator (iOS 26.2) the same swipe keeps the options open too. A photo-only message there sits 3pt under the message above it, which is just the row's top padding, and a long press on it opens its menu.
Screenshots
🤖 Generated with Claude Code