Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions runtime/src/esm_http_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,24 @@ fn http_import_failures_reject_with_the_cause() {
assert_eq!(invalid, "TypeError");
}

#[test]
fn worker_entry_served_over_http() {
let server = TestServer::start();
let o = server.origin.clone();
server.route("/ns/m/echo.worker.js", "text/javascript", "import { add } from './add.js';\nself.onmessage = (event) => self.postMessage(add(event.data));");
server.route("/ns/m/add.js", "text/javascript", "export const add = (n) => n + 1;");
let mut runtime = Runtime::new(".");
runtime.register_delegate_isolate_ptr();
let run = |path: &str| {
format!(
"new Promise((resolve, reject) => {{ const worker = new Worker(new URL('{o}{path}')); worker.onmessage = (event) => {{ worker.terminate(); event.type === 'messageerror' ? reject(event.error) : resolve(event.data); }}; worker.postMessage(41); }})"
)
};
assert_eq!(await_js(&mut runtime, &run("/ns/m/echo.worker.js")), "ok:42");
let missing = await_js(&mut runtime, &run("/ns/m/missing.worker.js"));
assert!(missing.starts_with("err:") && missing.contains("status=404"), "{missing}");
}

#[test]
fn native_websocket_round_trip() {
let server = TestServer::start();
Expand Down
10 changes: 10 additions & 0 deletions runtime/src/worker_support.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ pub fn install_worker_runtime(scope: &mut ContextScope<HandleScope>) {
return { source: input, filename: '[worker:eval]' };
}

// A dev server's URL (`new URL('./x.worker.ts', import.meta.url)` under HMR) isn't a
// file: the worker's thread imports it, so its own imports resolve against the URL.
if (/^https?:\/\//.test(input)) {
return { source: '', filename: input };
}

if (typeof globalThis.__nsResolveModulePath !== 'function' || typeof globalThis.__nsReadTextFile !== 'function') {
throw new Error('Worker file loading is unavailable: missing runtime host hooks');
}
Expand Down Expand Up @@ -90,6 +96,10 @@ pub fn install_worker_runtime(scope: &mut ContextScope<HandleScope>) {
typeof globalThis.__nsWorkerPollMessagesBlocking === 'function' &&
typeof globalThis.__nsWorkerTerminate === 'function';

if (!canUseThreadedHost && /^https?:\/\//.test(resolved.filename)) {
throw new Error('Loading a Worker from a URL needs the threaded worker host: ' + resolved.filename);
}

var channel = new MessageChannel();
var mainPort = channel.port1;
var workerPort = channel.port2;
Expand Down
6 changes: 5 additions & 1 deletion runtime/src/worker_threads.rs
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,11 @@ fn worker_bootstrap_script(source: &str, filename: &str) -> Result<String, Strin
}});
}};

if (typeof globalThis.__nsEvalAsModule === 'function') {{
if (/^https?:\/\//.test(__workerFilename)) {{
import(__workerFilename).catch(function (error) {{
__queueMessage({{ __workerError: String((error && error.message) || error) }});
}});
}} else if (typeof globalThis.__nsEvalAsModule === 'function') {{
globalThis.__nsEvalAsModule(__workerSource, __workerFilename || '[worker]');
}} else {{
const exec = new Function('__filename', __workerSource);
Expand Down
Loading