Repository navigation
fix: your open pull requests are listed even where the diffity App cannot read their reviews - #123
Conversation
…nnot read their reviews Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w
There was a problem hiding this comment.
Self-review: no issues found. Checked that the REST and GraphQL searches cover the same 50 newest pull requests, that a refused GraphQL node is left out by URL rather than breaking the list, and that a failed status read still lists every pull request. Tests pass locally (server 243).
— diffity review, requested by @fiddur
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the change that keeps users’ own pull requests visible when review details are unavailable.
No open issues 🎉
What changed in this PR
This PR keeps users’ own open pull requests visible when the diffity App cannot read their reviews. REST search supplies the list, while GraphQL adds review status where available.
Changes:
- Restore REST search for listing users’ own pull requests, with optional GraphQL status enrichment.
- Show “Status unknown” when review details are unavailable, while preserving draft badges.
- Extend test fixtures and coverage for inaccessible repositories and GraphQL failures.
| File | Description |
|---|---|
packages/server/tests/service.test.ts |
Verify REST listing, partial status enrichment, and GraphQL failure fallback. |
packages/server/tests/http.test.ts |
Verify inaccessible pull requests display draft and unknown-status indicators. |
packages/server/tests/helpers.ts |
Simulate forbidden GraphQL nodes alongside accessible results. |
packages/server/src/github.ts |
Separate REST listing from best-effort GraphQL review status lookup. |
packages/server/src/app.ts |
Render “Status unknown” when review details are unavailable. |
Review effort: Balanced
GraphQL refuses pull requests in repositories the App is not installed on, which failed the whole list. The list comes from the REST search again; GraphQL only adds who each waits on, and the rest say Status unknown.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w