NavMesh Place name support by AdamTadeusz · Pull Request #2092 · NeotokyoRebuild/neo

AdamTadeusz · 2026-08-24T20:20:54Z

Description

NeoAssets PR NeotokyoRebuild/neoAssets#132

Adds a hud element that displays the name of the closest nav area's place name, if any. Intended for incorporating call-outs from callout maps into the navigation meshes.

Also adds a command for displaying all nearby place names

placeCallouts.mp4

Toolchain

Windows MSVC VS2022

AdamTadeusz · 2026-08-28T20:03:00Z

I'm not happy with how client side the place names are loaded within the same function that reads the nav file, ideally that function should take a pointer to a CUtlVector and be moved to a separate file, with the original file calling it then going through all the place names and configuring how they look etc. but I'm tired.

…al game launch

AdamTadeusz · 2026-08-28T20:37:33Z

Ok fixed some last minute issues and included a video showing the feature

sunmachine

nitpick

set text length after copy Co-authored-by: Dan Peavey <sunMachine@users.noreply.github.com>

Update place nav area counts Co-authored-by: Dan Peavey <sunMachine@users.noreply.github.com>

remove incrementreferencecount Co-authored-by: Dan Peavey <sunMachine@users.noreply.github.com>

pragma once Co-authored-by: Dan Peavey <sunMachine@users.noreply.github.com>

…ide and textXPos textYPos

…adeusz/neo into 376_navPlaceNameHudSupport

sunmachine

BAM

…averageCenter, reference places, cap off placename string with a null terminator, increment navAreaCount beforehand

sunmachine

Nav-editing bug. I really hate in-game nav editing and review. Fuck this process. I'm going to make this completely obsolete mark my words.

AdamTadeusz · 2026-08-30T22:15:35Z

@sunmachine seems to me like clamping the place name before use solves this issue right?

AdamTadeusz · 2026-08-30T22:43:29Z

A long input is one thing, an empty is another. I figured this would also come in handy instead of relying on nav_place_pick ing a nav area without a place to allow clearing places with the paint function

sunmachine · 2026-08-30T23:03:10Z

@sunmachine seems to me like clamping the place name before use solves this issue right?

I think so! But I am broadly not keen on tying user-facing strings as IDs either (it's not a problem now but it's a localization smell eventually, assuming that's a thing we want to do one day). Good practice, not necessary for this "fix", just calling the smell as I saw it crop up as an actual editing bug.

Feel free to dismiss the review or update with the fix as you prescribed!

AdamTadeusz · 2026-08-31T07:59:33Z

@sunmachine seems to me like clamping the place name before use solves this issue right?

I think so! But I am broadly not keen on tying user-facing strings as IDs either (it's not a problem now but it's a localization smell eventually, assuming that's a thing we want to do one day). Good practice, not necessary for this "fix", just calling the smell as I saw it crop up as an actual editing bug.

Feel free to dismiss the review or update with the fix as you prescribed!

Yep 👍 it's in 448c909

sunmachine · 2026-08-31T13:06:49Z

@sunmachine seems to me like clamping the place name before use solves this issue right?

I think so! But I am broadly not keen on tying user-facing strings as IDs either (it's not a problem now but it's a localization smell eventually, assuming that's a thing we want to do one day). Good practice, not necessary for this "fix", just calling the smell as I saw it crop up as an actual editing bug.

Feel free to dismiss the review or update with the fix as you prescribed!

Yep 👍 it's in 448c909

Ohhh my bad I had no idea! The UI didn't annotate the commit in the first place like I expected it would, and didn't see the change. 🤪

init

af7eb4c

AdamTadeusz marked this pull request as draft August 24, 2026 20:22

custom place names

3f9ae6f

nullsystem added the Tournament Priority Issues to be prioritized for the upcoming NT;RE tournament label Aug 25, 2026

AdamTadeusz added 3 commits August 27, 2026 14:29

wip working example PointWorldText

41dad18

move neopointworldtext to new file

b772184

grab place names from nav mesh

2471e3c

DESTROYGIRL added the UI/HUD Relates to the HUD, NeoUI, menus, etc label Aug 28, 2026

move common enums to nav_shared, final touches

1e7a8c9

AdamTadeusz mentioned this pull request Aug 28, 2026

Navigation Mesh Callouts NeotokyoRebuild/neoAssets#132

Merged

AdamTadeusz added the Changes in neoAssets This PR depends on changes in the neoAssets repository. The relevant PR should be in the description label Aug 28, 2026

AdamTadeusz marked this pull request as ready for review August 28, 2026 19:50

AdamTadeusz requested review from a team and removed request for a team August 28, 2026 19:50

AdamTadeusz marked this pull request as draft August 28, 2026 19:52

Add an option to the keybinds menu

638e281

AdamTadeusz marked this pull request as ready for review August 28, 2026 19:56

AdamTadeusz requested a review from a team August 28, 2026 19:56

missing NEO guard

f982b06

AdamTadeusz marked this pull request as draft August 28, 2026 20:17

fix compiling with unity build disabled, radius not updating on initi…

1ae24a7

…al game launch

AdamTadeusz marked this pull request as ready for review August 28, 2026 20:37

sunmachine self-assigned this Aug 29, 2026

sunmachine requested changes Aug 29, 2026

View reviewed changes

Comment thread src/game/client/neo/c_neo_point_world_text.cpp Outdated

sunmachine reviewed Aug 29, 2026

View reviewed changes

Comment thread src/game/client/neo/ui/neo_hud_place_name.cpp

sunmachine requested changes Aug 29, 2026

View reviewed changes

Comment thread src/game/server/nav_area.cpp Outdated

sunmachine reviewed Aug 29, 2026

View reviewed changes

Comment thread src/game/server/neo/neo_player.cpp Outdated

sunmachine reviewed Aug 29, 2026

View reviewed changes

Comment thread src/game/client/neo/c_neo_point_world_text.cpp Outdated

sunmachine reviewed Aug 29, 2026

View reviewed changes

Comment thread src/game/client/neo/c_neo_point_world_text.h

sunmachine requested changes Aug 29, 2026

View reviewed changes

AdamTadeusz and others added 6 commits August 29, 2026 06:21

Update src/game/client/neo/c_neo_point_world_text.cpp

8bcaad0

set text length after copy Co-authored-by: Dan Peavey <sunMachine@users.noreply.github.com>

Update src/game/server/nav_area.cpp

9bb947d

Update place nav area counts Co-authored-by: Dan Peavey <sunMachine@users.noreply.github.com>

Update src/game/client/neo/c_neo_point_world_text.cpp

8226fc4

remove incrementreferencecount Co-authored-by: Dan Peavey <sunMachine@users.noreply.github.com>

Update src/game/client/neo/c_neo_point_world_text.h

975d25d

pragma once Co-authored-by: Dan Peavey <sunMachine@users.noreply.github.com>

don't repeatedly update m_szLastPlaceName when an empty string, use w…

8704807

…ide and textXPos textYPos

Merge branch '376_navPlaceNameHudSupport' of https://github.com/AdamT…

275a910

…adeusz/neo into 376_navPlaceNameHudSupport

sunmachine self-requested a review August 29, 2026 16:46

sunmachine previously approved these changes Aug 29, 2026

View reviewed changes

sunzenshen reviewed Aug 29, 2026

View reviewed changes

memdbgon, use GetLastKnownArea, call IGameSystem Remove, set initial …

64d2abe

…averageCenter, reference places, cap off placename string with a null terminator, increment navAreaCount beforehand

AdamTadeusz dismissed sunmachine’s stale review via 64d2abe August 30, 2026 10:28

AdamTadeusz requested a review from sunzenshen August 30, 2026 10:29

sunmachine removed their assignment Aug 30, 2026

sunmachine requested changes Aug 30, 2026

View reviewed changes

Comment thread src/game/server/nav_file.cpp

Clamp place name length before use, warn user of clamp

448c909

AdamTadeusz added 2 commits August 30, 2026 23:35

Empty string allows removing places

3b03876

don't forget nav_place_replace

f140d4c

AdamTadeusz requested a review from sunmachine August 30, 2026 22:43

sunmachine approved these changes Aug 31, 2026

View reviewed changes

sunzenshen approved these changes Aug 31, 2026

View reviewed changes

AdamTadeusz merged commit dbcf135 into NeotokyoRebuild:master Aug 31, 2026
7 checks passed

Uh oh!

Conversation

AdamTadeusz commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Toolchain

Uh oh!

AdamTadeusz commented Aug 28, 2026

Uh oh!

AdamTadeusz commented Aug 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sunmachine left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sunmachine left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sunmachine left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AdamTadeusz commented Aug 30, 2026

Uh oh!

AdamTadeusz commented Aug 30, 2026

Uh oh!

sunmachine commented Aug 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AdamTadeusz commented Aug 31, 2026

Uh oh!

sunmachine commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AdamTadeusz commented Aug 24, 2026 •

edited

Loading

sunmachine commented Aug 30, 2026 •

edited

Loading

sunmachine commented Aug 31, 2026 •

edited

Loading