Fix lost shutdown signal in MP3 player - #2102
Merged
sunzenshen merged 1 commit intoAug 30, 2026
Merged
Conversation
nullsystem
approved these changes
Aug 30, 2026
nullsystem
added
the
Tournament Priority
AdamTadeusz
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previous attempts to fix the MP3 player blocking game exit relied on sending an
EXITrequest through the worker channel. That request could be lost when the worker sent an unsolicitedReplyduring a long-running iteration.This commit instead latches shutdown state in a flag checked by the worker, removing the exit request from the worker channel entirely. The worker also only sends replies for calls it actually received, preventing the same lost-signal race from occurring again.
Toolchain
Linked Issues