Repository navigation
optimize javadoc escaping - #1007
Merged
Merged
Conversation
iuliiasobolevska
requested review from
asibross,
iparadiso,
jjacobs44,
paulbakker and
srinivasankavitha
as code owners
November 13, 2026 21:14
jjacobs44
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaDoc escaping introduced in #984 for #772 scans every description and repeats work for field, getter and builder documentation. Return ordinary descriptions unchanged, restrict markup parsing and Unicode regex scans to relevant input and reuse escaped descriptions within each generator instance. The HTML, inline-literal, comment-terminator and Unicode escaping rules remain unchanged.
Local comparison against
88728bd6, using the same large-schema fixture and byte-identical third-party dependency jars:JDK 17, G1, a 2 GiB maximum heap and eight writers; two fresh JVMs per variant with six warmups and ten measured iterations each, in before/after/after/before order.
The improvement repeated in both fork comparisons, although write-inclusive timing ranges overlap.
Main-thread allocation fell by 41 MB without writes and 56 MB with writes.
All 9,952 generated source and example files (41,945,234 bytes) are byte-identical and share the same path-and-content SHA-256 digest.