Repository navigation
Fix run() with callbacks never ending on NEURON - #866
Merged
apdavison merged 1 commit intoNov 19, 2026
Merged
Conversation
NEURON stops at the last time step before an off-grid target time, so when `time_point` is off the time grid, `t` cannot reach it and the loop does not end. A callback asking for less than one time step ahead also stalls the loop. Reported in NeuralEnsemble#815.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With callbacks,
run()andrun_until()can loop forever on NEURON. NEURON stops at the last time step before an off-grid target time, so when the end time is not a multiple of the time step (e.g.run(10.07)withdt = 0.1),tnever reaches it. A callback that asks to be called again less than one time step later stalls the loop in the same way (on NEST it raises an error instead).Here, we make each step of the callback loop advance by at least one time step, and stop the loop if a step makes no progress. On-grid runs behave as before. A callback asking for less than one time step ahead is now called once per time step, which is mentioned in the documentation.
The new system tests cover callback intervals that are not a multiple of the time step, intervals shorter than the time step (all backends), and an off-grid end time (NEURON, Brian2 and Arbor, since NEST does not accept off-grid times).
This replaces #815, which reported the problem.