Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pyNN/common/populations.py
Original file line number Diff line number Diff line change
Expand Up @@ -736,6 +736,8 @@ def id_to_index(self, id):
if isinstance(id, PopulationView):
id = id.all_cells
id = np.array(id)
if id.size == 0: # e.g. no recorded cells on this MPI node
return np.array([], dtype=int)
if (self.first_id > id.min()) or (self.last_id < id.max()):
raise ValueError("ids should be in the range [%d,%d], actually [%d, %d]" % (
self.first_id, self.last_id, id.min(), id.max()))
Expand Down
25 changes: 25 additions & 0 deletions test/unittests/test_population.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,13 @@ def test_id_to_index_with_array(self, sim=sim):
p = sim.Population(11, sim.IF_curr_alpha())
assert_array_equal(p.id_to_index(p.all_cells[3:9:2]), np.arange(3, 9, 2))

def test_id_to_index_with_empty_array(self, sim=sim):
# e.g. when no recorded cells are on this MPI node (#767)
p = sim.Population(11, sim.IF_curr_alpha())
index = p.id_to_index(np.array([], dtype=int))
assert index.size == 0
assert index.dtype.kind == "i"

def test_id_to_index_with_populationview(self, sim=sim):
p = sim.Population(11, sim.IF_curr_alpha())
view = p[3:7]
Expand Down Expand Up @@ -494,6 +501,24 @@ def test_get_spikes_with_gather(self, sim=sim):
assert_array_equal(seg1.spiketrains[7],
np.array([p.first_id + 7, p.first_id + 7 + 5]) % t3)

def test_get_spikes_on_mpi_node_with_no_cells(self, sim=sim):
# MPI node 2 of 3 has neither of the two cells (#767)
sim.simulator.state.num_processes = 3
sim.simulator.state.mpi_rank = 2
try:
p = sim.Population(2, sim.IF_cond_exp())
self.assertFalse(p._mask_local.any())
p.record('spikes')
sim.run(10.0)
# spike times as (ids, times) arrays, as returned by pyNN.nest
empty = (np.array([], dtype=int), np.array([]))
with patch.object(type(p.recorder), "_get_spiketimes", return_value=empty):
data = p.get_data(gather=False)
self.assertEqual(len(data.segments[0].spiketrains), 0)
finally:
sim.simulator.state.num_processes = 1
sim.simulator.state.mpi_rank = 0

# def test_get_data_no_gather(self, sim=sim):
# self.fail()

Expand Down
Loading