Repository navigation
Fix Quantity merging across concatenation semantics - #1979
Open
emanueldellipaoli01-a11y wants to merge 1 commit into
Open
emanueldellipaoli01-a11y wants to merge 1 commit into
emanueldellipaoli01-a11y wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes inconsistencies when merging Neo objects containing
Quantityvalues, making the behavior more reliable across different versions of thequantitieslibrary.The changes handle unit conversion explicitly before concatenation, avoiding unexpected behavior caused by differences in how
quantitiesinteracts withnp.concatenate. They also address merging ofUncertainQuantityannotations andSpikeTrainListobjects, along with related cases in other Neo objects.Regression tests have been added to cover the affected functionality, including relevant IO-related cases, and to ensure that compatible quantities expressed in different units are merged consistently.