Skip to content

[18.0][IMP] vault: add User security group to control module access - #975

Open
jans23 wants to merge 2 commits into
OCA:18.0from
Nitrokey:18.0-imp-vault-user-group
Open

[18.0][IMP] vault: add User security group to control module access#975
jans23 wants to merge 2 commits into
OCA:18.0from
Nitrokey:18.0-imp-vault-user-group

Conversation

@jans23

@jans23 jans23 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Introduce a new visible User security group under a dedicated "Vault" category. The whole module (menus, model access and record rules) is now gated behind this group instead of base.group_user. The group is implied by base.group_user so every internal user keeps access by default; removing the group from a user denies access to the vault without touching their keys.

@jans23
jans23 force-pushed the 18.0-imp-vault-user-group branch 3 times, most recently from 61e3baf to 50357ce Compare July 23, 2026 06:11
@jans23 jans23 changed the title [IMP] vault: add "Vault User" security group to control module access [IMP] vault: add User security group to control module access Jul 23, 2026
@jans23
jans23 force-pushed the 18.0-imp-vault-user-group branch from 50357ce to 4b4ed0d Compare July 23, 2026 06:48

@cvinh cvinh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes of course

@jans23
jans23 force-pushed the 18.0-imp-vault-user-group branch 3 times, most recently from 215295c to 8f68e5b Compare August 23, 2026 16:42
@cvinh

cvinh commented Aug 23, 2026

Copy link
Copy Markdown

The group is implied by base.group_user so every internal user keeps access by default;

This is not a good idea... but I think you force pushed to default user

@cvinh

cvinh commented Aug 23, 2026

Copy link
Copy Markdown

Maybe you can update readme to describe the feature

@jans23
jans23 force-pushed the 18.0-imp-vault-user-group branch from 8f68e5b to ff55e0e Compare August 24, 2026 04:07
@jans23

jans23 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

@cvinh I addressed your feedback. Thank you for that.

@jans23 jans23 changed the title [IMP] vault: add User security group to control module access [18.0][IMP] vault: add User security group to control module access Aug 24, 2026
@jans23

jans23 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

@CarlosRoca13 could you review this, please?

@OCA-git-bot OCA-git-bot added the mod:vault_share Module vault_share label Aug 24, 2026
jans23 added 2 commits August 25, 2026 10:32
Gate the module (menus, model access and record rules) behind a new
"User" group instead of base.group_user. The group is granted to new
users via base.default_user; removing the group from a specific user
denies access to the vault without touching their keys. Existing users
must be added to the group manually (or via shell) on upgrade.
@jans23
jans23 force-pushed the 18.0-imp-vault-user-group branch from e02681d to d96a4f2 Compare August 25, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:vault_share Module vault_share mod:vault Module vault series:18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants