Repository navigation
ci: repair base-branch CRDA and Labeler workflows #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
ac441f4
ab28a55
3034c16
405e9d6
6d2ce43
d336678
41c7fa2
aab6c26
b2df5fd
b959206
9dc83f2
6e2a53a
d695d22
2f94253
3583848
51dca44
c189497
23ea59e
7bead2d
035b94d
e27d5ba
62c7338
5291c1f
88adf2e
1840525
3dfabee
83a2f2e
e8b8705
b0b0b14
7058925
079e955
74f9bb0
54f5c60
e04372e
3a395d6
65a998e
8396a66
a36e79c
5c045a5
07f6271
cf73be8
8ecee3c
47abd0b
a4be707
920fbf8
ce0f5e7
20397bd
8597f15
7daa773
a369085
1add91e
ceac556
eaecf85
7797bf0
48b0a5a
a543020
6424650
8f7e2ca
81df1fb
457827d
73814a2
61857f3
9c43682
326065e
e601b80
f7739ce
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2,17 +2,6 @@ name: Endor Labs | |||||||||||||||||||
|
|
||||||||||||||||||||
| on: | ||||||||||||||||||||
| workflow_dispatch: | ||||||||||||||||||||
|
zskbot marked this conversation as resolved.
Resolved
Comment on lines
3
to
4
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removing
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: .github/workflows/endorlabs.yml
Line: 3-4
Comment:
**Missing namespace breaks CI**
Removing `inputs.namespace` leaves the Endor scan reading an input that maintainers can no longer supply. It also breaks the existing assertion in `tests/repository-config.test.mjs:27`, so the main CI job fails during `npm test`. Restore the required namespace input.
```suggestion
on:
workflow_dispatch:
inputs:
namespace:
description: Endor Labs tenant namespace
required: true
type: string
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly. |
||||||||||||||||||||
| inputs: | ||||||||||||||||||||
| namespace: | ||||||||||||||||||||
| description: Endor Labs tenant namespace | ||||||||||||||||||||
| required: true | ||||||||||||||||||||
| type: string | ||||||||||||||||||||
|
|
||||||||||||||||||||
| permissions: | ||||||||||||||||||||
| contents: read | ||||||||||||||||||||
| security-events: write | ||||||||||||||||||||
| actions: read | ||||||||||||||||||||
| id-token: write | ||||||||||||||||||||
|
|
||||||||||||||||||||
| jobs: | ||||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removing the permissions block also removes
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: .github/workflows/endorlabs.yml
Line: 6
Comment:
**Endor scans cannot sign in**
Removing the permissions block also removes `id-token: write`, which the Endor action needs for its default GitHub OIDC sign-in. This workflow supplies no alternative credentials. Manual scans therefore cannot sign in even after the namespace input is restored. Keep the explicit permissions, including `security-events: write` for the report upload.
```suggestion
permissions:
contents: read
security-events: write
actions: read
id-token: write
jobs:
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly. |
||||||||||||||||||||
| scan: | ||||||||||||||||||||
|
|
||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,8 +13,6 @@ | |
| name: SLSA generic generator | ||
| on: | ||
| workflow_dispatch: | ||
| release: | ||
| types: [created] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,8 +4,7 @@ | |
| name: Node.js Package | ||
|
|
||
| on: | ||
| release: | ||
| types: [created] | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ name: Python Package using Conda | |
|
|
||
| on: | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| build-linux: | ||
| runs-on: ubuntu-latest | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.