Repository navigation
Add OCodeJS square-corner brand, auth and console preview - #55
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
| function showView(name){site.style.display=name==='site'?'block':'none';footer.style.display=name==='site'?'block':'none';auth.classList.toggle('active',name==='auth');consoleView.classList.toggle('active',name==='console');document.getElementById('top').style.display='flex';window.scrollTo(0,0)} | ||
| document.querySelectorAll('[data-view]').forEach(el=>el.addEventListener('click',e=>{e.preventDefault();showView(el.dataset.view)})); | ||
| document.querySelectorAll('a[href="#auth"]').forEach(el=>el.addEventListener('click',e=>{if(!el.hasAttribute('data-view')){e.preventDefault();showView('auth')}})); | ||
| document.querySelectorAll('a[href="#home"]').forEach(el=>el.addEventListener('click',e=>{if(auth.classList.contains('active')||consoleView.classList.contains('active')){e.preventDefault();showView('site')}})); |
There was a problem hiding this comment.
After opening authentication or the console, the header’s Products, Features, MCP and Docs links point to sections hidden by showView. The authentication screen’s legal links also point to the hidden footer. Only #home restores the site, so these links change the address without showing their content. Restore the site before following links to its sections.
Prompt To Fix With AI
This is a comment left during a code review.
Path: brand-preview/index.html
Line: 85
Comment:
**Section links stop working**
After opening authentication or the console, the header’s Products, Features, MCP and Docs links point to sections hidden by `showView`. The authentication screen’s legal links also point to the hidden footer. Only `#home` restores the site, so these links change the address without showing their content. Restore the site before following links to its sections.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.| .auth-view{display:none;min-height:calc(100vh - var(--header));align-items:center;justify-content:center;padding:48px 20px}.auth-view.active{display:flex}.auth-card{width:min(440px,100%);border:1px solid var(--line);background:#101012;padding:32px}.auth-brand{display:flex;justify-content:center;margin-bottom:25px}.auth-card h2{text-align:center;font:700 24px/1.25 var(--mono);letter-spacing:-.06em;margin:0 0 9px}.auth-card .sub{text-align:center;font-size:12px;color:var(--muted);margin:0 0 24px}.social{width:100%;margin:6px 0;min-height:44px}.social .social-icon{font-size:15px}.divider{display:flex;align-items:center;gap:12px;color:var(--dim);font:11px var(--mono);margin:20px 0}.divider:before,.divider:after{content:"";height:1px;background:var(--line);flex:1}.field{display:block;margin:13px 0}.field span{display:block;font:10px var(--mono);color:#d4d4d8;margin-bottom:7px}.field input{width:100%;height:44px;border:1px solid var(--line);background:#09090b;color:#fff;padding:0 12px;border-radius:0;outline:none}.field input:focus{border-color:#fafafa}.field input::placeholder{color:#52525b}.auth-submit{width:100%;margin-top:7px}.terms{text-align:center;color:var(--dim);font-size:10px;line-height:1.7;margin:18px 0}.terms a,.switch a{color:#fff;text-decoration:underline;text-underline-offset:3px}.switch{text-align:center;color:var(--muted);font-size:11px;margin:0}.demo-warning{border:1px solid #49412d;background:#17140d;color:#d4c39a;padding:10px;font-size:10px;line-height:1.5;margin-bottom:16px} | ||
| .console-view{display:none;padding:40px 0 80px}.console-view.active{display:block}.console-head{display:flex;justify-content:space-between;align-items:end;margin-bottom:24px}.console-head h2{font:700 30px var(--mono);letter-spacing:-.06em;margin:6px 0}.console-tabs{display:flex;gap:0;border-bottom:1px solid var(--line);margin-bottom:20px;overflow:auto}.console-tabs button{background:none;color:var(--muted);border:0;border-bottom:2px solid transparent;padding:12px 15px;font:11px var(--mono);white-space:nowrap}.console-tabs button.active{color:#fff;border-bottom-color:#fff}.console-panel{display:none}.console-panel.active{display:block}.console-grid{display:grid;grid-template-columns:repeat(3,1fr);gap:10px}.metric-card{padding:20px;border:1px solid var(--line);background:#0b0b0d}.metric-card .label{color:var(--dim);font-size:9px}.metric{font-size:25px;margin:12px 0 3px}.metric-card p{color:var(--muted);font-size:11px;margin:0}.data-table{width:100%;border-collapse:collapse;border:1px solid var(--line);font-size:11px}.data-table th,.data-table td{text-align:left;padding:13px;border-bottom:1px solid var(--line)}.data-table th{font:9px var(--mono);color:var(--dim);background:#101012}.data-table td{color:#d4d4d8}.key-row{display:flex;justify-content:space-between;gap:12px;align-items:center;border:1px solid var(--line);padding:13px;margin:8px 0;font:11px var(--mono)} | ||
| @media(max-width:850px){.links{gap:13px}.hero{grid-template-columns:1fr;padding:65px 0 55px;min-height:auto}.orb-stage{height:320px;grid-row:1}.orb{width:250px}.hero-copy{text-align:center}.hero-copy p{margin:auto}.actions{justify-content:center}.grid{grid-template-columns:repeat(2,1fr)}.feature-grid{grid-template-columns:repeat(2,1fr)}.mcp-grid{grid-template-columns:repeat(2,1fr)}} | ||
| @media(max-width:620px){.wrap{width:calc(100% - 30px)}.links{display:none}.menu{display:block}.nav-right .icon-link{display:none}.hero{padding-top:35px}.orb-stage{height:260px}.orb{width:210px}.section-head{display:block}.section-head p{margin-top:14px}.grid,.feature-grid,.split,.footer-grid,.console-grid{grid-template-columns:1fr}.tile{min-height:165px}.footer-grid{gap:20px}.footer-bottom{display:block;line-height:2}.auth-card{padding:24px 18px}.console-head{display:block}.console-head .btn{margin-top:12px}.data-table{min-width:520px}.table-scroll{overflow:auto}} |
There was a problem hiding this comment.
Opening the mobile menu puts all four links into the same unwrapped header row as the brand and sign-in controls. At phone widths, that row cannot fit and spills sideways. Give the open menu a separate row or dropdown layout so visitors can use it without scrolling sideways.
Prompt To Fix With AI
This is a comment left during a code review.
Path: brand-preview/index.html
Line: 20
Comment:
**Mobile menu spills sideways**
Opening the mobile menu puts all four links into the same unwrapped header row as the brand and sign-in controls. At phone widths, that row cannot fit and spills sideways. Give the open menu a separate row or dropdown layout so visitors can use it without scrolling sideways.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| <header id="top"><div class="wrap nav"> | ||
| <a class="brand" href="#home" aria-label="ocodejs home"><span class="mark" aria-hidden="true"></span><span>ocodejs</span></a> | ||
| <nav class="links" aria-label="Primary navigation"><a href="#products">Products</a><a href="#features">Features</a><a href="#integrations">MCP</a><a href="#docs">Docs</a></nav> | ||
| <div class="nav-right"><a class="icon-link" href="https://github.com/OCodejs" aria-label="GitHub">GH</a><button class="btn small" data-view="auth">Sign in</button><button class="menu" aria-label="Open menu" onclick="document.querySelector('.links').style.display=document.querySelector('.links').style.display==='flex'?'none':'flex'">☰</button></div> |
There was a problem hiding this comment.
Desktop navigation stays hidden
Opening and closing the mobile menu leaves an inline display:none on .links. Widening the window past 620px then hides the menu button but keeps the navigation hidden, because the inline style overrides the desktop rule. Toggle a class scoped to mobile styles instead, or clear the inline style when the window widens.
Prompt To Fix With AI
This is a comment left during a code review.
Path: brand-preview/index.html
Line: 28
Comment:
**Desktop navigation stays hidden**
Opening and closing the mobile menu leaves an inline `display:none` on `.links`. Widening the window past 620px then hides the menu button but keeps the navigation hidden, because the inline style overrides the desktop rule. Toggle a class scoped to mobile styles instead, or clear the inline style when the window widens.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.| document.querySelectorAll('[data-view]').forEach(el=>el.addEventListener('click',e=>{e.preventDefault();showView(el.dataset.view)})); | ||
| document.querySelectorAll('a[href="#auth"]').forEach(el=>el.addEventListener('click',e=>{if(!el.hasAttribute('data-view')){e.preventDefault();showView('auth')}})); | ||
| document.querySelectorAll('a[href="#home"]').forEach(el=>el.addEventListener('click',e=>{if(auth.classList.contains('active')||consoleView.classList.contains('active')){e.preventDefault();showView('site')}})); | ||
| document.querySelectorAll('.console-tabs button').forEach(btn=>btn.addEventListener('click',()=>{document.querySelectorAll('.console-tabs button').forEach(b=>b.classList.toggle('active',b===btn));document.querySelectorAll('.console-panel').forEach(p=>p.classList.toggle('active',p.id==='tab-'+btn.dataset.tab))})); | ||
| let login=false;document.addEventListener('click',e=>{if(e.target&&e.target.id==='switch-auth'){e.preventDefault();login=!login;document.getElementById('auth-title').textContent=login?'Log in to ocodejs':'Create your ocodejs account';document.getElementById('auth-sub').textContent=login?'Continue to your ocodejs workspace.':'Get high-quality inference, low-cost subscriptions, and team collaboration tools.';document.getElementById('continue').textContent=login?'Log in':'Continue';document.getElementById('auth-switch').innerHTML=login?'New to ocodejs? <a href="#" id="switch-auth">Create account</a>':'Already have an account? <a href="#" id="switch-auth">Log in</a>';}}); | ||
| document.getElementById('continue').addEventListener('click',()=>alert('This is a visual preview. Authentication is not connected.')); |
There was a problem hiding this comment.
New interactions lack required tests
The new view switching, console tabs, authentication toggle and mobile menu have no accompanying tests. The root AGENTS.md requires: “Add or update tests for the code you change, even if nobody asked.” Add tests for these interactions, including links between views and mobile menu behavior. This repository requirement must be met before merging.
Context Used: AGENTS.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: brand-preview/index.html
Line: 83-88
Comment:
**New interactions lack required tests**
The new view switching, console tabs, authentication toggle and mobile menu have no accompanying tests. The root `AGENTS.md` requires: “Add or update tests for the code you change, even if nobody asked.” Add tests for these interactions, including links between views and mobile menu behavior. This repository requirement must be met before merging.
**Context Used:** AGENTS.md ([source](https://github.com/ocodejs/ocodejs/blob/main/AGENTS.md))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary
brand-preview/.border-radius: 0).Safety
The preview is isolated, but the repository’s requirement to add tests must be met before merging.
Fix with agent prompt
Summary
Adds an isolated static brand preview with landing sections, signup/login screens and four console tabs.
Reviews (1) · Last reviewed commit: "Document OCodeJS brand preview scope and..." · Reviewed by Greptile