Skip to content

Add GitHub Super Linter workflow - #57

Merged
zskbot merged 1 commit into
OCodejs:mainfrom
zskbot:main
Nov 11, 2026
Merged

zskbot merged 1 commit into
OCodejs:mainfrom
zskbot:main

Conversation

@zskbot

@zskbot zskbot commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

This workflow runs linters on code changes for the main branch.

Purpose

Describe the problem and intended result.

Scope and source protection

  • Every added or changed file is listed.
  • Existing files are changed only within the explicitly approved scope.
  • No unrelated refactors, renames, or formatting changes are included.
  • No secrets, credentials, or production data are included.
  • Public exports and existing behavior remain compatible, or breaking changes are documented.

Verification

  • npm test passes.
  • npm pack --dry-run passes.
  • Tests cover new behavior and relevant edge cases.
  • Known issues and unverified assumptions are listed below.

Release safety

  • No release/tag or paid resource was created without explicit approval.
  • This pull request will not be merged until reviewed and approved.

Test results and limitations

List the commands actually run and their results.

Summary by Sourcery

CI:

  • Add a GitHub Actions workflow that runs Super-Linter on changed files for pushes and pull requests targeting the main branch.

RetriggerView in GreptileConfidence Score: 5/5

The workflow appears safe to merge; no blocking issues were found.

Summary

Adds .github/workflows/super-linter.yml to lint changes on pushes and pull requests targeting main.

  • Pushes and pull requests to main now run Super-Linter on changed files.

Reviews (1) · Last reviewed commit: "Add GitHub Super Linter workflow" · Reviewed by Greptile

This workflow runs linters on code changes for the main branch.

Signed-off-by: zskbot <241179063+zskbot@users.noreply.github.com>
@vercel

vercel Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@zskbot is attempting to deploy a commit to the OCodejs Team on Vercel.

A member of the Team first needs to authorize it.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@sourcery-ai

sourcery-ai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Configuration

Add a GitHub Actions workflow that runs Super Linter on pushes and pull requests targeting the main branch.

  • .github/workflows/super-linter.yml L1-29

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@zskbot
zskbot merged commit 096f595 into OCodejs:main Nov 11, 2026
12 of 15 checks passed
Comment thread .github/workflows/super-linter.yml Resolved

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 2 issues

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path=".github/workflows/super-linter.yml" line_range="25" />
<code_context>
+          fetch-depth: 0
+
+      - name: Lint Code Base
+        uses: github/super-linter@v4
+        env:
+          VALIDATE_ALL_CODEBASE: false
</code_context>
<issue_to_address>
**Mutable linter reference exposes token**

When the upstream `v4` tag is moved or compromised, gitHub resolves `@v4` to the changed action code, which runs with `secrets.GITHUB_TOKEN` in its environment and can exfiltrate the token or exercise its granted permissions.

Pin Super-Linter to a reviewed full commit SHA and explicitly grant only the token permissions it needs.
</issue_to_address>

### Comment 2
<location path=".github/workflows/super-linter.yml" line_range="25-29" />
<code_context>
+          fetch-depth: 0
+
+      - name: Lint Code Base
+        uses: github/super-linter@v4
+        env:
+          VALIDATE_ALL_CODEBASE: false
+          DEFAULT_BRANCH: "main"
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
</code_context>
<issue_to_address>
**Workflow has no regression tests**

No test is added or updated for this workflow, so the repository has no test coverage for its triggers or Super-Linter configuration and regressions in the new behavior go undetected.

Add a test or workflow-validation check that verifies the new workflow's triggers and configuration.
</issue_to_address>

Sourcery assessment

Needs a human reviewer. 2 findings to address first, and the workflow passes the repository's GITHUB_TOKEN to the Super-Linter action on pushes and pull requests, so a defect or compromised action could use the token's granted permissions during a run. Reverting stops future runs, but cannot undo any repository access or changes made with a token before it expires.

Blocking findings: .github/workflows/super-linter.yml:25, .github/workflows/super-linter.yml:29


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread .github/workflows/super-linter.yml Resolved
Comment thread .github/workflows/super-linter.yml Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants