Skip to content

fix: address CLI Hub canonical-link review findings - #2

Merged
zskbot merged 28 commits into
mainfrom
fix/cli-hub-followup-review-findings
Nov 12, 2026
Merged

zskbot merged 28 commits into
mainfrom
fix/cli-hub-followup-review-findings

Conversation

@zskbot

@zskbot zskbot commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Update all 21 standalone pages under pages/ to use the canonical OCodejs/cli-hub repository links.
  • Remove obsolete zskbot.github.io/ocodejs-cli catalog fallback expectations and assert the canonical raw catalog source.
  • Correct the security documentation anchor to #github-authentication.
  • Add the canonical repository URL to README and strengthen regression coverage.

Validation

  • Catalog validation and unit tests are running on the latest PR head.
  • CodeQL Advanced and PR quality checks are also running.
  • An earlier validation attempt failed on stale test assertions; the branch was updated and the latest run is being evaluated independently.

Scope and safety

  • Changes are isolated to fix/cli-hub-followup-review-findings; no direct edits to main.
  • No DNS, CNAME, GitHub Pages settings, secrets, Production deploy or merge performed by this change.
  • PR intentionally remains open for review.

@sourcery-ai

sourcery-ai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Uses of the API

Point the security-details link to the current GitHub authentication documentation section.

  • index.html L1538

UI

Update standalone page source-repository links to the canonical OCodejs/cli-hub repository.

  • pages/agents.html L12 (removed lines)
  • pages/api-reference.html L12 (removed lines)
  • pages/changelog.html L12 (removed lines)
  • pages/collections.html L12 (removed lines)
  • pages/command-builder.html L12 (removed lines)
  • pages/community.html L12 (removed lines)
  • pages/docs.html L12 (removed lines)
  • pages/environments.html L12 (removed lines)
  • pages/favorites.html L12 (removed lines)
  • pages/install-guides.html L12 (removed lines)
  • pages/integrations.html L12 (removed lines)
  • pages/mcp.html L12 (removed lines)
  • pages/projects.html L12 (removed lines)
  • pages/releases.html L12 (removed lines)
  • pages/snippets.html L12 (removed lines)
  • pages/terminal.html L12 (removed lines)
  • pages/tool-details.html L12 (removed lines)
  • pages/tools.html L12 (removed lines)
  • pages/workflows.html L12 (removed lines)
  • pages/workspace.html L12 (removed lines)

Documentation

Document the canonical repository URL in the README.

  • README.md L6-7

Tests

Update catalog and UI regression assertions to match canonical catalog sources and current rendered markup.

  • tests/catalog.test.mjs L167-170, L248-251 (+5 small edits)

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T15:34:23.370630Z 9f4da84 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
auth-server Ready Ready Preview Nov 12, 2026 3:29pm UTC
cli Ready Ready Preview Nov 12, 2026 3:29pm UTC
cli-hub-auth-server Ready Ready Preview Nov 12, 2026 3:29pm UTC

Request Review

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 2 issues

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="pages/agents.html" line_range="12" />
<code_context>
-</style></head><body><div class="shell"><aside><a class="brand" href="../index.html">&gt;_ OCode.js<small>CLI HUB / 25 PAGES</small></a><nav><a href="../index.html">Home</a><a href="index.html">All pages</a><a href="workspace.html">Workspace</a><a href="tools.html">Tools</a><a href="agents.html">AI Agents</a><a href="integrations.html">Integrations</a><a href="docs.html">Docs</a></nav></aside><header><span>OCODE.JS / CLI HUB</span><a href="../index.html">← Home</a></header><main><div class="eyebrow">OCode.js CLI Hub / agents</div><h1>AI Agents</h1><p>Công cụ và workflow dành cho AI coding agents.</p><section class="panel"><strong>Overview</strong><p>Công cụ và workflow dành cho AI coding agents. Trang này là điểm truy cập riêng trong cấu trúc 25 trang của OCode.js CLI Hub.</p></section><section class="panel"><strong>Availability & safety</strong><p>Đây là giao diện tĩnh và tài liệu nền tảng. Tính năng cần backend, quyền truy cập hoặc runtime thực thi sẽ chỉ được bật sau khi tích hợp và kiểm thử. Không có lệnh terminal nào được thực thi từ trang này.</p></section><a class="btn" href="index.html">Browse all pages →</a><a class="btn" href="../index.html#tools">Open tools catalog →</a><a class="btn" href="https://github.com/zskbot/ocodejs-cli">Source repository ↗</a></main><footer>© 2026 OCode.js · Static workspace</footer></div></body></html>
</code_context>
<issue_to_address>
**Visitors reach obsolete repository**

When a visitor follows the Source repository link from either the Workflows or Workspace page, the links in `pages/workflows.html` and `pages/workspace.html` still point to `zskbot/ocodejs-cli`, so visitors land on the former repository instead of the canonical CLI Hub.

Update both pages’ Source repository links to the canonical repository URL.

Also at `README.md:6`.
</issue_to_address>

### Comment 2
<location path="tests/catalog.test.mjs" line_range="230" />
<code_context>
     'new URL("tools.json",document.baseURI).href',
-    '"https://zskbot.github.io/ocodejs-cli/tools.json"',
-    '"https://raw.githubusercontent.com/zskbot/ocodejs-cli/main/tools.json"',
+    '"https://raw.githubusercontent.com/OCodejs/cli-hub/main/tools.json"',
     "setTimeout(()=>{controller.abort();reject(new Error(\"Request timed out · \"+new URL(source).host))},5000)",
     "Promise.race([request,deadline])",
</code_context>
<issue_to_address>
**Canonical fallback goes unchecked**

When the canonical URL remains elsewhere in `index.html` but is removed from `CATALOG_SOURCES`, the `catalog loading...` test only checks `html.includes(required)` at line 238, and the canonical-link test does the same at line 247. If the URL remains elsewhere in `index.html` after being removed from `CATALOG_SOURCES`, both tests pass even though `loadCatalog` never tries that fallback; users see a catalog failure when the other sources are unavailable.

Extract or match the `CATALOG_SOURCES` array and assert that the canonical URL is one of its entries.
</issue_to_address>

Sourcery assessment

Approval pending. 2 findings to address first.

Blocking findings: pages/agents.html:12, tests/catalog.test.mjs:230


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread pages/agents.html Resolved
Comment thread tests/catalog.test.mjs Resolved
sourcery-ai[bot]
sourcery-ai Bot previously approved these changes Nov 12, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sourcery assessment

Approved.

@sourcery-ai
sourcery-ai Bot dismissed their stale review November 12, 2026 15:29

Sourcery withdrew this approval because the latest commits introduced blocking findings.

sourcery-ai[bot]
sourcery-ai Bot previously approved these changes Nov 12, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sourcery assessment

Approved.

@sourcery-ai
sourcery-ai Bot dismissed their stale review November 12, 2026 15:31

Sourcery withdrew this approval because the latest commits introduced blocking findings.

@zskbot
zskbot merged commit 49f07d2 into main Nov 12, 2026
10 of 11 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9f4da8416f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant