Repository navigation
fix: address CLI Hub canonical-link review findings - #2
Conversation
Reviewer's GuideUses of the APIPoint the security-details link to the current GitHub authentication documentation section.
UIUpdate standalone page source-repository links to the canonical OCodejs/cli-hub repository.
DocumentationDocument the canonical repository URL in the README.
TestsUpdate catalog and UI regression assertions to match canonical catalog sources and current rendered markup.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="pages/agents.html" line_range="12" />
<code_context>
-</style></head><body><div class="shell"><aside><a class="brand" href="../index.html">>_ OCode.js<small>CLI HUB / 25 PAGES</small></a><nav><a href="../index.html">Home</a><a href="index.html">All pages</a><a href="workspace.html">Workspace</a><a href="tools.html">Tools</a><a href="agents.html">AI Agents</a><a href="integrations.html">Integrations</a><a href="docs.html">Docs</a></nav></aside><header><span>OCODE.JS / CLI HUB</span><a href="../index.html">← Home</a></header><main><div class="eyebrow">OCode.js CLI Hub / agents</div><h1>AI Agents</h1><p>Công cụ và workflow dành cho AI coding agents.</p><section class="panel"><strong>Overview</strong><p>Công cụ và workflow dành cho AI coding agents. Trang này là điểm truy cập riêng trong cấu trúc 25 trang của OCode.js CLI Hub.</p></section><section class="panel"><strong>Availability & safety</strong><p>Đây là giao diện tĩnh và tài liệu nền tảng. Tính năng cần backend, quyền truy cập hoặc runtime thực thi sẽ chỉ được bật sau khi tích hợp và kiểm thử. Không có lệnh terminal nào được thực thi từ trang này.</p></section><a class="btn" href="index.html">Browse all pages →</a><a class="btn" href="../index.html#tools">Open tools catalog →</a><a class="btn" href="https://github.com/zskbot/ocodejs-cli">Source repository ↗</a></main><footer>© 2026 OCode.js · Static workspace</footer></div></body></html>
</code_context>
<issue_to_address>
**Visitors reach obsolete repository**
When a visitor follows the Source repository link from either the Workflows or Workspace page, the links in `pages/workflows.html` and `pages/workspace.html` still point to `zskbot/ocodejs-cli`, so visitors land on the former repository instead of the canonical CLI Hub.
Update both pages’ Source repository links to the canonical repository URL.
Also at `README.md:6`.
</issue_to_address>
### Comment 2
<location path="tests/catalog.test.mjs" line_range="230" />
<code_context>
'new URL("tools.json",document.baseURI).href',
- '"https://zskbot.github.io/ocodejs-cli/tools.json"',
- '"https://raw.githubusercontent.com/zskbot/ocodejs-cli/main/tools.json"',
+ '"https://raw.githubusercontent.com/OCodejs/cli-hub/main/tools.json"',
"setTimeout(()=>{controller.abort();reject(new Error(\"Request timed out · \"+new URL(source).host))},5000)",
"Promise.race([request,deadline])",
</code_context>
<issue_to_address>
**Canonical fallback goes unchecked**
When the canonical URL remains elsewhere in `index.html` but is removed from `CATALOG_SOURCES`, the `catalog loading...` test only checks `html.includes(required)` at line 238, and the canonical-link test does the same at line 247. If the URL remains elsewhere in `index.html` after being removed from `CATALOG_SOURCES`, both tests pass even though `loadCatalog` never tries that fallback; users see a catalog failure when the other sources are unavailable.
Extract or match the `CATALOG_SOURCES` array and assert that the canonical URL is one of its entries.
</issue_to_address>Sourcery assessment
Approval pending. 2 findings to address first.
Blocking findings: pages/agents.html:12, tests/catalog.test.mjs:230
Sourcery withdrew this approval because the latest commits introduced blocking findings.
Sourcery withdrew this approval because the latest commits introduced blocking findings.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f4da8416f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
pages/to use the canonicalOCodejs/cli-hubrepository links.zskbot.github.io/ocodejs-clicatalog fallback expectations and assert the canonical raw catalog source.#github-authentication.Validation
Scope and safety
fix/cli-hub-followup-review-findings; no direct edits tomain.