Skip to content

fix: remove conflicting custom domain and use GitHub Pages fallback - #3

Merged
zskbot merged 3 commits into
mainfrom
fix/pages-fallback-domain-conflict
Nov 12, 2026
Merged

zskbot merged 3 commits into
mainfrom
fix/pages-fallback-domain-conflict

Conversation

@zskbot

@zskbot zskbot commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Remove the repository-level CNAME that claims ocodejs.dev, a domain allocated to another OCodeJS service.
  • Set the HTML canonical URL and Open Graph URL to the repository's GitHub Pages fallback: https://ocodejs.github.io/cli-hub/
  • Update README hosting guidance to document GitHub Pages as the static-site host and Vercel as optional.

Validation

  • Verified the updated canonical and Open Graph URLs in index.html.
  • Verified no remaining https://ocodejs.dev/ root-domain canonical reference in index.html.
  • Existing GitHub Pages deployment workflow on the current main completed successfully; this PR does not trigger a Pages deployment.

Safety

  • No DNS records changed.
  • No changes to other OCodeJS services or hostnames.
  • No Vercel production deployment attempted.
  • PR is open for review; no merge performed.

Summary by Sourcery

Use the GitHub Pages fallback instead of the conflicting custom domain for the CLI Hub.

Bug Fixes:

  • Remove the conflicting custom-domain claim and update site metadata and catalog fallback URLs to use the repository’s GitHub Pages address.

Enhancements:

  • Document GitHub Pages as the canonical hosting fallback and clarify that Vercel is optional.

Documentation:

  • Update hosting guidance to reflect the GitHub Pages URL and the removal of custom-domain configuration.

@vercel

vercel Bot commented Nov 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
auth-server Ready Ready Preview Nov 12, 2026 3:39pm UTC

Request Review

@sourcery-ai

sourcery-ai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Uses of the API

Update the catalog fallback fetch to use the GitHub Pages URL so runtime loading no longer depends on the conflicting custom domain.

  • index.html L1818

UI

Set the page’s canonical and Open Graph URLs to the GitHub Pages fallback so shared and indexed pages identify the new public URL.

  • index.html L9-13

Configuration

Remove the repository-level CNAME so GitHub Pages no longer claims the conflicting custom domain.

  • CNAME (deleted)

Documentation

Document GitHub Pages as the static-site fallback and clarify that Vercel is optional and no custom domain is configured.

  • README.md L115-119

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T15:42:27.848913Z e23a0f2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 3 issues

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="index.html" line_range="9" />
<code_context>
 <title>OCode.js CLI Hub — Developer tools</title>
 <meta name="description" content="Khám phá, tìm kiếm và sử dụng các công cụ CLI/TUI dành cho developer và AI agents.">
-<link rel="canonical" href="https://ocodejs.dev/">
+<link rel="canonical" href="https://ocodejs.github.io/cli-hub/">
 <meta property="og:type" content="website">
 <meta property="og:title" content="OCode.js CLI Hub">
</code_context>
<issue_to_address>
**Old domain retains auth access**

When a user has an active auth-worker session and JavaScript runs on the service still hosted at `https://ocodejs.dev`, `auth-worker` still trusts `APP_ORIGIN=https://ocodejs.dev`; its credentialed CORS permits that origin, and `/auth/session` returns a CSRF token that lets the caller read `/api/github/repos`. JavaScript running on the other service at that domain can therefore read a logged-in user's private repository metadata.

Remove the old domain from the auth worker's allowed origin and configure authentication for the actual frontend origin with an appropriate cross-site cookie policy.

Also at `README.md:119`.
</issue_to_address>

### Comment 2
<location path="index.html" line_range="9" />
<code_context>
 <title>OCode.js CLI Hub — Developer tools</title>
 <meta name="description" content="Khám phá, tìm kiếm và sử dụng các công cụ CLI/TUI dành cho developer và AI agents.">
-<link rel="canonical" href="https://ocodejs.dev/">
+<link rel="canonical" href="https://ocodejs.github.io/cli-hub/">
 <meta property="og:type" content="website">
 <meta property="og:title" content="OCode.js CLI Hub">
</code_context>
<issue_to_address>
**Fallback login and sessions fail**

When the documented auth Worker is deployed and visitors use GitHub Pages, the Worker’s old `APP_ORIGIN` rejects exact-origin requests and redirects OAuth callbacks to `ocodejs.dev`; changing it alone still leaves the `SameSite=Lax` cookie off cross-site fetches, so users cannot authenticate or use sessions.

Set the Worker’s allowed and callback origin to GitHub Pages, and change the session flow or cookie policy to support its cross-site requests.

Also at `README.md:117`.
</issue_to_address>

### Comment 3
<location path="index.html" line_range="9" />
<code_context>
 <title>OCode.js CLI Hub — Developer tools</title>
 <meta name="description" content="Khám phá, tìm kiếm và sử dụng các công cụ CLI/TUI dành cho developer và AI agents.">
-<link rel="canonical" href="https://ocodejs.dev/">
+<link rel="canonical" href="https://ocodejs.github.io/cli-hub/">
 <meta property="og:type" content="website">
 <meta property="og:title" content="OCode.js CLI Hub">
</code_context>
<issue_to_address>
**Browser workspace data disappears**

When a user saved workspace data on the prior custom-domain origin before the site moves to GitHub Pages, the browser stores projects, activity, favorites, and prompt queues in origin-scoped `localStorage`; the new GitHub Pages host therefore reads empty storage instead of data saved on the prior custom-domain origin, so returning users see a fresh workspace and cannot access their existing data there.

Provide a safe export/import migration or warn users to back up their local workspace data before the origin change.

Also at `README.md:117`.
</issue_to_address>

Sourcery assessment

Approval pending. 3 findings to address first.

Blocking findings: index.html:9, index.html:9, index.html:9


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread index.html Resolved
Comment thread index.html Resolved
Comment thread index.html Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e23a0f21fd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread index.html Resolved
@zskbot
zskbot merged commit cbb4171 into main Nov 12, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant