Repository navigation
fix: remove conflicting custom domain and use GitHub Pages fallback - #3
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reviewer's GuideUses of the APIUpdate the catalog fallback fetch to use the GitHub Pages URL so runtime loading no longer depends on the conflicting custom domain.
UISet the page’s canonical and Open Graph URLs to the GitHub Pages fallback so shared and indexed pages identify the new public URL.
ConfigurationRemove the repository-level CNAME so GitHub Pages no longer claims the conflicting custom domain.
DocumentationDocument GitHub Pages as the static-site fallback and clarify that Vercel is optional and no custom domain is configured.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Hey - I've found 3 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="index.html" line_range="9" />
<code_context>
<title>OCode.js CLI Hub — Developer tools</title>
<meta name="description" content="Khám phá, tìm kiếm và sử dụng các công cụ CLI/TUI dành cho developer và AI agents.">
-<link rel="canonical" href="https://ocodejs.dev/">
+<link rel="canonical" href="https://ocodejs.github.io/cli-hub/">
<meta property="og:type" content="website">
<meta property="og:title" content="OCode.js CLI Hub">
</code_context>
<issue_to_address>
**Old domain retains auth access**
When a user has an active auth-worker session and JavaScript runs on the service still hosted at `https://ocodejs.dev`, `auth-worker` still trusts `APP_ORIGIN=https://ocodejs.dev`; its credentialed CORS permits that origin, and `/auth/session` returns a CSRF token that lets the caller read `/api/github/repos`. JavaScript running on the other service at that domain can therefore read a logged-in user's private repository metadata.
Remove the old domain from the auth worker's allowed origin and configure authentication for the actual frontend origin with an appropriate cross-site cookie policy.
Also at `README.md:119`.
</issue_to_address>
### Comment 2
<location path="index.html" line_range="9" />
<code_context>
<title>OCode.js CLI Hub — Developer tools</title>
<meta name="description" content="Khám phá, tìm kiếm và sử dụng các công cụ CLI/TUI dành cho developer và AI agents.">
-<link rel="canonical" href="https://ocodejs.dev/">
+<link rel="canonical" href="https://ocodejs.github.io/cli-hub/">
<meta property="og:type" content="website">
<meta property="og:title" content="OCode.js CLI Hub">
</code_context>
<issue_to_address>
**Fallback login and sessions fail**
When the documented auth Worker is deployed and visitors use GitHub Pages, the Worker’s old `APP_ORIGIN` rejects exact-origin requests and redirects OAuth callbacks to `ocodejs.dev`; changing it alone still leaves the `SameSite=Lax` cookie off cross-site fetches, so users cannot authenticate or use sessions.
Set the Worker’s allowed and callback origin to GitHub Pages, and change the session flow or cookie policy to support its cross-site requests.
Also at `README.md:117`.
</issue_to_address>
### Comment 3
<location path="index.html" line_range="9" />
<code_context>
<title>OCode.js CLI Hub — Developer tools</title>
<meta name="description" content="Khám phá, tìm kiếm và sử dụng các công cụ CLI/TUI dành cho developer và AI agents.">
-<link rel="canonical" href="https://ocodejs.dev/">
+<link rel="canonical" href="https://ocodejs.github.io/cli-hub/">
<meta property="og:type" content="website">
<meta property="og:title" content="OCode.js CLI Hub">
</code_context>
<issue_to_address>
**Browser workspace data disappears**
When a user saved workspace data on the prior custom-domain origin before the site moves to GitHub Pages, the browser stores projects, activity, favorites, and prompt queues in origin-scoped `localStorage`; the new GitHub Pages host therefore reads empty storage instead of data saved on the prior custom-domain origin, so returning users see a fresh workspace and cannot access their existing data there.
Provide a safe export/import migration or warn users to back up their local workspace data before the origin change.
Also at `README.md:117`.
</issue_to_address>Sourcery assessment
Approval pending. 3 findings to address first.
Blocking findings: index.html:9, index.html:9, index.html:9
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e23a0f21fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
ocodejs.dev, a domain allocated to another OCodeJS service.Validation
index.html.https://ocodejs.dev/root-domain canonical reference inindex.html.Safety
Summary by Sourcery
Use the GitHub Pages fallback instead of the conflicting custom domain for the CLI Hub.
Bug Fixes:
Enhancements:
Documentation: