Repository navigation
fix: use staging Worker account-specific workers.dev host - #51
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reviewer's GuideTestsPoint the staging control API smoke test at the account-specific workers.dev host so CI avoids the challenged custom-domain route.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="scripts/check-control-api-staging.mjs" line_range="1" />
<code_context>
-const BASE = (process.env.CONTROL_API_BASE || "https://api-staging.ocodejs.co/api/v1").replace(/\/$/, "");
+const BASE = (process.env.CONTROL_API_BASE || "https://ocodejs-server-api-staging.huynhthuongg2505-f9b.workers.dev/api/v1").replace(/\/$/, "");
const ORIGIN = "https://ocodejs.co";
const MAX_AGE_MS = 60_000;
</code_context>
<issue_to_address>
**Dashboard remains on unrelated API host**
When the new hostname resolves and passes the smoke test while the dashboard still uses its existing base URL, `index.html` still sends dashboard requests to `ocodejs-server-api-staging.ocodejs-df1.workers.dev`, while this smoke test now checks the `huynhthuongg2505-f9b` host. The check can pass while the dashboard still cannot reach the active Worker, so users continue to see API data as unavailable.
Update the dashboard endpoint and the staging endpoint references in the runbook to the verified host, or make the check explicitly report that the dashboard still targets a different host.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: scripts/check-control-api-staging.mjs:1
|
Deployment failed for project ocodejs.github.io with the following error: Learn More: https://vercel.com/ocodejs-co?upgradeToPro=build-rate-limit |
|
Deployment failed for project pages.ocodejs.theme with the following error: Learn More: https://vercel.com/ocodejs-co?upgradeToPro=build-rate-limit |
Summary
workers.devhostname belonging to the Cloudflare account that actually owns the enabledocodejs-server-api-stagingWorker and its custom-domain binding.api-staging.ocodejs.coroute, which is served through the zone's browser challenge and returns Cloudflarecf-mitigated: challenge(403) to non-browser CI clients.ocodejs-df1.workers.devhostname, which belongs to a different Cloudflare account than the Worker currently bound toapi-staging.ocodejs.co.Safety
Summary by Sourcery
Bug Fixes: