Repository navigation
fix: follow redirects for internal CLI Auth probe - #54
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
Reviewer's GuideImplementationConfigure the internal CLI Auth health probe to follow redirects, matching the MCP probe’s policy.
TestsUpdate the probe test to expect redirects to be followed.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Deployment failed for project ocodejs.github.io with the following error: Learn More: https://vercel.com/ocodejs-co?upgradeToPro=build-rate-limit |
|
Deployment failed for project pages.ocodejs.theme with the following error: Learn More: https://vercel.com/ocodejs-co?upgradeToPro=build-rate-limit |
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="workers/control-api/worker.mjs" line_range="181" />
<code_context>
headers: { Accept: "application/json" },
cache: "no-store",
- redirect: "error",
+ redirect: "follow",
signal: AbortSignal.timeout(4000)
});
</code_context>
<issue_to_address>
**Healthy probe test fails**
When the service-registry test probes CLI Auth, the mocked `fetch` asserts `options.redirect === "error"`, but `probeCliAuth` passes `"follow"`; the assertion throws, the probe reports CLI Auth unavailable, and the healthy-state assertion fails.
Update the mocked `fetch` assertion to expect `redirect: "follow"`.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: workers/control-api/worker.mjs:181
Summary
redirect: "follow".cli-auth: healthyvia the internalocodejs-authservice binding, with GitHub OAuth/PAT bindings configured.Validation
/services:control-api,cli-auth, andmcp-serverhealthy.auth.ocodejs.devstill returns Cloudflare challenge; this change does not alter public routing or security mode.Keep unmerged pending review.
Summary by Sourcery
Fix the internal CLI Auth health probe to follow redirects and report service health correctly.
Bug Fixes:
Tests: