Repository navigation
Enhance JSON handling in concepts API and update tests - #14
Merged
Merged
Conversation
- Updated the `concept_ids`, `relationship_types`, `vocabulary_ids`, and `domain_ids` in the API to preserve JSON array structure by using unname and as.list. - Modified tests to reflect these changes, ensuring that the body of requests maintains the correct format for concept recommendations. - Added `httpuv` as a suggested dependency in DESCRIPTION. - Documented improvements in NEWS.md regarding JSON array preservation for various filters.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
concept_ids,relationship_types,vocabulary_ids, anddomain_idsin the API to preserve JSON array structure by using unname and as.list.httpuvas a suggested dependency in DESCRIPTION.Summary by cubic
Fixes JSON encoding in
concepts$batchandconcepts$recommendedso filter parameters preserve JSON array structure, including single values and named input vectors. Previously httr2 auto-unboxed single-element and named vectors into JSON scalars and objects, breaking the expected request format.httpuvas a suggested dependency to inspect the real JSON wire format viareq_dry_run.vocabulary_filterentries are non-missing strings before sending.NEWS.md.Written for commit 475acce. Summary will update on new commits.