Publish a version once, when its release is published - #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish workflow deploys on a push to
mainas well as on a published release, so merging a release branch intomaindeploys the version, and publishing the GitHub release deploys the same coordinates again. WithautoPublishset, the second attempt fails on a version that is already published.This did not show until now because the
releasetrigger listened forcreated, which does not fire when a release is saved as a draft and published later — so in practice only the push tomainever deployed. Now that the trigger ispublished, both fire.Removing
mainfrom the push trigger leavesdeveloppublishing snapshots and the release publishing versions, which is what the tag is for and how eforms-core-java already works. The 1.9.0 release of that library published itself correctly this way.