Repository navigation
feat(navigator): add a permission-gated skygrid entry - #532
Merged
Merged
Conversation
Contributor
Gradle Builds captured by gradle/actions/setup-gradleBuild PR :: build
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SkyGrid runs on the network, but the lobby offered no way to reach it, so even the team had to connect by hand. It is not ready for every player yet, so a plain entry for everyone was not an option.
Solution
The navigator's server row now shows SkyGrid after Build, for players with
titan.navigator.skygrid. Everyone else sees the menu as before. A click checks the permission again and sends the player to the SkyGrid server. With four servers the row stays centred, so Survival, Creative and Build move one slot to the left for players who see all of them.Implements the
navigator-skygridOpenSpec change (#530).Tests
Navigator unit tests cover the entry with and without the permission, the click and the centred row. The smoke tests pass.