Repository navigation
refactor: [SDK-5538] add SdkOperation names for init-gated entry points - #2800
Draft
abdulraqeeb33 wants to merge 1 commit into
Draft
abdulraqeeb33 wants to merge 1 commit into
abdulraqeeb33 wants to merge 1 commit into
Conversation
SdkOperation names each public entry point that waits for or requires init, so logs name the call the app made. Adds an isMissing overload that takes an operation and parameter name. Nothing uses it yet; the never-crash init path in this stack does. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Oct 16, 2026
Contributor
📊 Diff Coverage ReportDiff Coverage Report (Changed Lines Only)Gate: aggregate coverage on changed executable lines must be ≥ 80% (JaCoCo line data for lines touched in the diff). Changed Files Coverage
Overall (aggregate gate)24/24 touched executable lines covered (100.0% — requires ≥ 80%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack (base
feat/never-crash, merged tomainas one unit; split out of #2793):Description
One Line Summary
Add
SdkOperation, the names of the public entry points that wait for or require init, so logs name the call the app made.Details
Motivation
Part of SDK-5538: never crash the app on an invalid init or calls before init. The never-crash path logs which call was ignored; this gives those logs one source of names instead of string literals.
Scope
SdkOperationenum and anisMissing(value, operation, parameter)overload inInputGuard.Testing
Unit testing
InputGuardTestscovers the new overload. core, location, in-app-messages, notifications, spotless, detekt and apiCheck pass.Manual testing
Not needed, no behavior change.
Affected code checklist
Checklist
Overview
Testing
Final pass