Repository navigation
chore: [CI] Retry CocoaPods Trunk pushes until the version is published - #1767
Merged
Merged
Conversation
pod trunk push can fail with "Calling the GitHub commit API timed out" whether or not CocoaPods published the version. The publish step now asks the Trunk API whether the version is published before pushing and after a failed push, and pushes again up to three times before it fails the job.
nan-li
marked this pull request as ready for review
October 8, 2026 21:15
Collaborator
|
In sdk-shared we have .github/actions/wait-for-cocoapods-pod but I guess its not really applicable here |
fadi-george
approved these changes
Oct 8, 2026
Contributor
Author
that's for the wrappers right. I can see if we can re-use it somehow for consistency |
Contributor
Author
Looked and this step and the wrappers wait-for-cocoapods is solving 2 different issues. The wrappers need to wait for someone else’s release to show up. This step decides whether to push. The other action polls the CDN for OneSignalXCFramework only, and the CDN trails Trunk by minutes, so it can’t tell the publish step whether to skip a push, so we can't reuse it in the same way here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Retry CocoaPods publishing in
publish-release.ymluntil CocoaPods confirms the version is published.Details
Motivation
pod trunk pushcan fail with "Calling the GitHub commit API timed out" whether or not CocoaPods published the version. Releasing5.8.0took four workflow attempts (see the failed attempts here). Two of the three timed-out pushes had published the pod anyway, and one had not.Scope
Testing
Unit testing
Not applicable, workflow-only change.
Manual testing
I ran the step's script locally with macOS bash 3.2 and a fake
podcommand:5.8.0skips both pods as it already exists. A version that does not exist gets 3 push attempts and then fails the job.❗️ Not run in Actions yet. The next release is the first real run.
Affected code checklist
Checklist
Overview
Testing
Final pass
🤖 Generated with Claude Code