Skip to content

fix(ctrace): report trace-run reference diagnostics - #2590

Merged
thorstendb-ARM merged 1 commit into
mainfrom
fix-ctrace-reference-diagnostics
Sep 3, 2026
Merged

fix(ctrace): report trace-run reference diagnostics#2590
thorstendb-ARM merged 1 commit into
mainfrom
fix-ctrace-reference-diagnostics

Conversation

@thorstendb-ARM

Copy link
Copy Markdown
Contributor

Summary

Report info, warning, and error annotations for every ctrace-ref retained by the ctrace configuration reader, including ITM stimulus port 0.

References of types not consumed by ctrace remain ignored.

Behavior

  • Annotation severity is preserved in the ctrace output.
  • Reference error annotations are non-failing because the referenced metadata may still be valid.
  • Normal validation continues afterward and determines whether the requested outputs can be generated.
  • Diagnostic context includes the configuration path, reference name, type, and processor name where available.

Tests

  • Extended unit coverage for all annotation severities and ITM channel 0.
  • Verified that unsupported reference types remain ignored.
  • Verified that normal output validation still runs after a reference error.
  • Added an end-to-end integration test covering logging, exit status, and CSV/CTF generation.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.40%. Comparing base (97f2159) to head (b695677).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2590      +/-   ##
==========================================
- Coverage   72.40%   72.40%   -0.01%     
==========================================
  Files         185      185              
  Lines       30401    30399       -2     
  Branches    17929    17928       -1     
==========================================
- Hits        22013    22011       -2     
  Misses       6079     6079              
  Partials     2309     2309              
Flag Coverage Δ
ctrace-cov 99.81% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/ctrace/src/control/TraceDirectoryJob.cpp 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Test Results

  4 files   -    39    4 suites   - 123   1s ⏱️ - 18m 26s
193 tests  -   936  193 ✅  -   919  0 💤  - 17  0 ❌ ±0 
386 runs   - 2 011  379 ✅  - 1 960  7 💤  - 51  0 ❌ ±0 

Results for commit b695677. ± Comparison against base commit 97f2159.

This pull request removes 938 and adds 2 tests. Note that renamed tests count towards both.
AuxCmdTests ‑ MkdirCmdTest
AuxCmdTests ‑ RmdirCmdTest
AuxCmdTests ‑ TouchCmdTest
BuildSystemGeneratorTests ‑ GenAuditFile
BuildSystemGeneratorTests ‑ GenAuditFile_WithOut_Existing_Audit_File
BuildSystemGeneratorTests ‑ GenAuditFile_With_Existing_Audit_File
BuildSystemGeneratorTests ‑ GetString
BuildSystemGeneratorTests ‑ StrConv
BuildSystemGeneratorTests ‑ StrNorm
CBuildGCCTests ‑ Asm
…
CtraceIntegTests ‑ ReportsDiagnosticsFromConsumedTraceRunReferences
CtraceUnitTests ‑ testTraceDirectoryChecksOutputRequirementsAfterReferenceError

@thorstendb-ARM
thorstendb-ARM merged commit 9662836 into main Sep 3, 2026
25 of 26 checks passed
@thorstendb-ARM
thorstendb-ARM deleted the fix-ctrace-reference-diagnostics branch September 3, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants